Paths

Table of Contentst

Differential D1161

The inclusion of this patch addresses T169 Tilix
ClosedPublic
Actions

Authored by joebonrichie on Oct 6 2017, 12:43 PM.

Tags

None

Referenced Files

	F11047165: D1161.id3715.diff
	Thu, Aug 10, 2:55 PM

	F11047164: D1161.id.diff
	Thu, Aug 10, 2:55 PM

	F11047163: D1161.id2803.diff
	Thu, Aug 10, 2:55 PM

	F11047162: D1161.id3306.diff
	Thu, Aug 10, 2:55 PM

	F11047161: D1161.id3714.diff
	Thu, Aug 10, 2:55 PM

	F11032978: D1161.diff
	Wed, Aug 9, 3:00 PM

	F11000755: D1161.diff
	Sat, Jul 29, 2:37 PM

	F10933594: D1161.id3306.diff
	Jul 12 2023, 7:48 AM

View All 15 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

R3876:61d5eb45af22: The inclusion of this patch addresses T169 Tilix

Summary

The inclusion of this patch addresses T169 Tilix

Tilix is an advanced GTK3 tiling terminal
emulator that follows the Gnome Human Interface Guidelines.
This patch addresses T169

Test Plan

After installation tilix can be launched within the
desktop environment

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

doc-E-brown created this revision.Oct 6 2017, 12:43 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptOct 6 2017, 12:43 PM

doc-E-brown edited the summary of this revision. (Show Details)Oct 7 2017, 10:36 AM

joebonrichie requested changes to this revision.Nov 9 2017, 7:10 PM

joebonrichie added a subscriber: joebonrichie.

joebonrichie added inline comments.

package.yml
8	Typo, should be `system.utils`
18	Not required as it is part of `system.base` as well as a dependency of `desktop-file-utils`
19–20	If these as well as `pkgconfig(x11)` are replaced with `pkgconfig(gtk+-3.0)` instead how many extra dependencies does that bring in? It's kind of a nit pick, but I think it will make it look tidier.

This revision now requires changes to proceed.Nov 9 2017, 7:10 PM

Updated to version 1.7.1
Revised dependencies as per review comments

joebonrichie accepted this revision.Nov 15 2017, 8:49 PM

This revision is now accepted and ready to land.Nov 15 2017, 8:49 PM

Might be worth @ikey reviewing this as it requires networking.

I don't believe this is build-able with networking disabled currently.

Commandeering to add the Makefile.

This revision now requires review to proceed.Dec 1 2017, 1:54 PM

add makefile

Closed by commit R3876:61d5eb45af22: The inclusion of this patch addresses T169 Tilix (authored by doc-E-brown, committed by joebonrichie). · Explain WhyDec 1 2017, 2:04 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

1 line

8 lines

22 lines

pspec_x86_64.xml

51 lines

Diff 3715

Makefile

Loading...

abi_used_libs

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...