Page MenuHomeSolus

Initial commit of grpc
ClosedPublic

Authored by YakoYakoYokuYoku on Aug 10 2021, 10:50 PM.

Details

Summary

In a sisyphean effort to reduce both build time and size of tensorflow grpc should be spun off instead of being vendored.

Depends on D11617.

Signed-off-by: Martin Reboredo <yakoyoku@gmail.com>

Test Plan

Build against tensorflow (TBD).

Diff Detail

Repository
R5416 grpc
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

YakoYakoYokuYoku requested review of this revision.Aug 10 2021, 10:50 PM
JoshStrobl requested changes to this revision.Aug 25 2021, 6:05 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
44

We should really only bother building the plugins tensorflow needs specifically, if any.

This revision now requires changes to proceed.Aug 25 2021, 6:05 PM

Update to 1.41.1.

JoshStrobl requested changes to this revision.Dec 27 2021, 7:10 PM
JoshStrobl added inline comments.
package.yml
23

Did you check that these weren't already getting added as rundeps due to linking?

This revision now requires changes to proceed.Dec 27 2021, 7:10 PM
DataDrake accepted this revision.Jan 14 2022, 6:15 PM
DataDrake removed a reviewer: JoshStrobl.
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Jan 14 2022, 6:15 PM
This revision was automatically updated to reflect the committed changes.