Page MenuHomeSolus
Differential D11618

Initial commit of grpc
ClosedPublic
Actions

Authored by YakoYakoYokuYoku on Aug 10 2021, 10:50 PM.
Tags
None
Referenced Files
F10836864: D11618.diff
Thu, Jun 8, 9:06 PM
F10773350: D11618.id.diff
Sun, May 21, 8:29 PM
F10765153: D11618.diff
Fri, May 19, 11:29 AM
F10738756: D11618.id30812.diff
Sat, May 13, 2:03 PM
F10738750: D11618.id29886.diff
Sat, May 13, 2:02 PM
F10738748: D11618.id28130.diff
Sat, May 13, 2:02 PM
F10738742: D11618.id.diff
Sat, May 13, 1:59 PM
F10720572: D11618.diff
May 5 2023, 10:41 PM
View All 13 Files
Subscribers
DataDrake
JoshStrobl

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Commits
R5416:fa7e7ac1ee47: Initial commit of grpc
Summary

In a sisyphean effort to reduce both build time and size of tensorflow grpc should be spun off instead of being vendored.

Depends on D11617.

Signed-off-by: Martin Reboredo <yakoyoku@gmail.com>

Test Plan

Build against tensorflow (TBD).

Diff Detail

Repository
R5416 grpc
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

YakoYakoYokuYoku created this revision.Aug 10 2021, 10:50 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptAug 10 2021, 10:50 PM
Harbormaster completed remote builds in B1343: Diff 28130.Aug 10 2021, 10:50 PM
YakoYakoYokuYoku requested review of this revision.Aug 10 2021, 10:50 PM
JoshStrobl requested changes to this revision.Aug 25 2021, 6:05 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
44

We should really only bother building the plugins tensorflow needs specifically, if any.

This revision now requires changes to proceed.Aug 25 2021, 6:05 PM
YakoYakoYokuYoku updated this revision to Diff 29886.Nov 13 2021, 10:53 PM

Update to 1.41.1.

Harbormaster completed remote builds in B2447: Diff 29886.Nov 13 2021, 10:53 PM
JoshStrobl requested changes to this revision.Dec 27 2021, 7:10 PM
JoshStrobl added inline comments.
package.yml
23

Did you check that these weren't already getting added as rundeps due to linking?

This revision now requires changes to proceed.Dec 27 2021, 7:10 PM
DataDrake accepted this revision.Jan 14 2022, 6:15 PM
DataDrake removed a reviewer: JoshStrobl.
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Jan 14 2022, 6:15 PM
Closed by commit R5416:fa7e7ac1ee47: Initial commit of grpc (authored by YakoYakoYokuYoku, committed by DataDrake). · Explain WhyJan 14 2022, 6:30 PM
This revision was automatically updated to reflect the committed changes.
DataDrake added a commit: R5416:fa7e7ac1ee47: Initial commit of grpc.

Revision Contents
Changeset List

PathSize
1 line
11 lines
8744 lines
23 lines
602 lines
files/
12 lines
63 lines
355 lines

Diff 30812

View Options

Makefile

Loading...
View Options

abi_libs

Loading...
View Options

abi_symbols

Loading...
View Options

abi_used_libs

Loading...
View Options

abi_used_symbols

Loading...
View Options

files/grpc-assert.patch

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.