Differential D11618

Initial commit of grpc
ClosedPublic
Actions

Authored by YakoYakoYokuYoku on Aug 10 2021, 10:50 PM.

Tags

None

Subscribers

DataDrake, JoshStrobl

Details

Reviewers

Group Reviewers

Commits

R5416:fa7e7ac1ee47: Initial commit of grpc

Summary

In a sisyphean effort to reduce both build time and size of tensorflow grpc should be spun off instead of being vendored.

Depends on D11617.

Signed-off-by: Martin Reboredo <yakoyoku@gmail.com>

Test Plan

Build against tensorflow (TBD).

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

YakoYakoYokuYoku created this revision.Aug 10 2021, 10:50 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptAug 10 2021, 10:50 PM

Harbormaster completed remote builds in B1343: Diff 28130.Aug 10 2021, 10:50 PM

YakoYakoYokuYoku requested review of this revision.Aug 10 2021, 10:50 PM

JoshStrobl requested changes to this revision.Aug 25 2021, 6:05 PM

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

package.yml
44	We should really only bother building the plugins tensorflow needs specifically, if any.

This revision now requires changes to proceed.Aug 25 2021, 6:05 PM

Update to 1.41.1.

Harbormaster completed remote builds in B2447: Diff 29886.Nov 13 2021, 10:53 PM

JoshStrobl requested changes to this revision.Dec 27 2021, 7:10 PM

JoshStrobl added inline comments.

package.yml
23	Did you check that these weren't already getting added as rundeps due to linking?

This revision now requires changes to proceed.Dec 27 2021, 7:10 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Jan 14 2022, 6:15 PM

Closed by commit R5416:fa7e7ac1ee47: Initial commit of grpc (authored by YakoYakoYokuYoku, committed by DataDrake). · Explain WhyJan 14 2022, 6:30 PM

This revision was automatically updated to reflect the committed changes.

DataDrake added a commit: R5416:fa7e7ac1ee47: Initial commit of grpc.

Revision Contents
Changeset List

			Path	Packages
A	M		Makefile (1 line)
A	M		abi_libs (11 lines)
A	M		abi_symbols (8744 lines)
A	M		abi_used_libs (23 lines)
A	M		abi_used_symbols (602 lines)
A	M		files/grpc-assert.patch (12 lines)
A	M		package.yml (63 lines)
A	M		pspec_x86_64.xml (355 lines)

Diff 30812

Makefile

Loading...

abi_libs

Loading...

abi_symbols

Loading...

abi_used_libs

Loading...

abi_used_symbols

Loading...

files/grpc-assert.patch

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...