Page MenuHomeSolus

The inclusion of this patch addresses T169 Tilix

Authored by joebonrichie on Oct 6 2017, 12:43 PM.



The inclusion of this patch addresses T169 Tilix

Tilix is an advanced GTK3 tiling terminal
emulator that follows the Gnome Human Interface Guidelines.
This patch addresses T169

Test Plan

After installation tilix can be launched within the
desktop environment

Diff Detail

R3876 tilix
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

doc-E-brown created this revision.Oct 6 2017, 12:43 PM
doc-E-brown edited the summary of this revision. (Show Details)Oct 7 2017, 10:36 AM
joebonrichie requested changes to this revision.Nov 9 2017, 7:10 PM
joebonrichie added a subscriber: joebonrichie.
joebonrichie added inline comments.

Typo, should be system.utils


Not required as it is part of system.base as well as a dependency of desktop-file-utils


If these as well as pkgconfig(x11) are replaced with pkgconfig(gtk+-3.0) instead how many extra dependencies does that bring in? It's kind of a nit pick, but I think it will make it look tidier.

This revision now requires changes to proceed.Nov 9 2017, 7:10 PM
doc-E-brown edited edge metadata.

Updated to version 1.7.1
Revised dependencies as per review comments

joebonrichie accepted this revision.Nov 15 2017, 8:49 PM
This revision is now accepted and ready to land.Nov 15 2017, 8:49 PM

Might be worth @ikey reviewing this as it requires networking.

I don't believe this is build-able with networking disabled currently.

joebonrichie commandeered this revision.Dec 1 2017, 1:54 PM
joebonrichie edited reviewers, added: doc-E-brown; removed: joebonrichie.

Commandeering to add the Makefile.

This revision now requires review to proceed.Dec 1 2017, 1:54 PM
joebonrichie updated this revision to Diff 3714.Dec 1 2017, 1:55 PM

add makefile

This revision was automatically updated to reflect the committed changes.