With this patch python can first try and dlopen .so.avx2 libs if
they exist on the system and the cpu is supported.
This is neccessary as python dlopens solib files and as such standard
glibc hwcaps mechasism can't be used.
Details
Details
- Reviewers
JoshStrobl - Group Reviewers
Triage Team - Commits
- R2527:9b6b1a4362b2: Enable support for python to dlopen .so.avx2 libs
Confirm .so.avx2 libs are loaded on a supported system
Confirm normal .so libs are loaded if .so.avx2 libs don't exist
TODO: ensure .so.avx2 files are ignored on a non-supported system.
Diff Detail
Diff Detail
- Repository
- R2527 python3
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Just realized that since we compile for haswell and __builtin_cpu_supports only checks for avx2 here it could lead to segfaults on amd excavator. Will expand the cpu checks to be more like glibc haswell platform see here.
Comment Actions
Will also need to backport this patch from gcc if cpu capabilities are expanded. Linking here for future reference. https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=a0b4e09ab0102d9c0a5e6d603a080cb78600c40d
Comment Actions
Closing this as the ypkg PR has been merged and our ypkg has been updated to have this macro.