update bat to 0.18.2
ClosedPublic
Actions

Authored by sethfl on Jul 13 2021, 11:55 AM.

Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Commits

R4509:1a34acb7ce0a: update bat to 0.18.2

Summary

Changelog:

Features
- Ignore known backup/template filename suffixes when selecting the syntax
Other
- Add bash completion
- Fix Clippy lints
- Add syntax highlighting test files
Syntaxes
- Upgraded Julia syntax to fix a highlighting bug
- Added support for dash and XAML
- Apply DotENV syntax for for .env.default and .env.defaults files

Test Plan

View some files

Diff Detail

Repository

R4509 bat

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sethfl created this revision.Jul 13 2021, 11:55 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptJul 13 2021, 11:55 AM

sethfl requested review of this revision.Jul 13 2021, 11:55 AM

Harbormaster completed remote builds in B1081: Diff 27714.Jul 13 2021, 11:55 AM

Other

Add bash completion

I don't see any bash completion file. There are completions only for fish and zsh.

You can add it like this:
find ./ -name bat.bash -exec install -Dm00644 {} $installdir/usr/share/bash-completion/completions/bat \;
or :
install -Dm00644 assets/completions/bat.bash.in $installdir/usr/share/bash-completion/completions/bat

install -Dm00644 assets/completions/bat.bash.in $installdir/usr/share/bash-completion/completions/bat

Don't do that. That file is a template file (see its extension .in). I'm in favor of removing all the find calls, but targeting the right files.

@livingsilver94 is right. Just compiled and the target files for completions are in:
target/debug/build/bat-e80b9fedac527dea/out/assets/completions/
target/release/build/bat-e80b9fedac527dea/out/assets/completions/
The manual is in:
target/debug/build/bat-e80b9fedac527dea/out/assets/manual/
target/release/build/bat-e80b9fedac527dea/out/assets/manual/
Files in both locations are identical. So I think using find command is fine.

actually add the bash completions (oops)

Harbormaster completed remote builds in B1085: Diff 27718.Jul 14 2021, 1:12 AM

sethfl added inline comments.Jul 14 2021, 1:15 AM

package.yml
25	I think I found a good compromise between @livingsilver94 and @algent's suggestions (plus the absolute path to the files won't have to be updated for every new version).

To avoid using find, you probably can run install against e.g. target/release/build/*/out/assets/manual/. I'm pretty sure it is guaranteed that only one dir will be inside build.

Yea globbing should work. Alternatively just interpolate ${version} into the path.

This revision now requires changes to proceed.Jul 16 2021, 10:15 AM

replace find with file globbing

Harbormaster completed remote builds in B1105: Diff 27754.Jul 17 2021, 12:50 AM

sethfl added inline comments.Jul 17 2021, 12:52 AM

package.yml
22–25	Interpolating `${version}` doesn't work here as the build folder for `bat` is not named after the version number (ex: `bat-e80b9fedac527dea` instead of `bat-0.18.2`)