Page MenuHomeSolus

Fix path to executable in sunshine.service
ClosedPublic

Authored by Jacek on Jul 8 2021, 8:23 PM.

Details

Summary

Add -D SUNSHINE_EXECUTABLE_PATH=/usr/bin/sunshine to fix path to executable in sunshine.service

Test Plan

Enabled sunshine service successfully
Tested basic sunshine functionality works again

Diff Detail

Repository
R5262 sunshine
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1028
Build 1028: arc lint + arc unit

Event Timeline

Jacek created this revision.Jul 8 2021, 8:23 PM
Jacek requested review of this revision.Jul 8 2021, 8:23 PM
Jacek added a comment.Jul 8 2021, 8:28 PM

I'm really sorry I missed that previously, even though I used sunshine for quite a while I haven't used all its features. So recently I have been going through and checking all of them and it turns out I never checked if Systemd service works. Turns out it didn't, and it expected binary in /home/build/YPKG/root/sunshine/build/sunshine.git/build/sunshine.
So if you wanted to make Sunshine run on each boot, it would fail. No other functionality was affected. Sorry I discovered it so late, after the original diff was already accepted.

JoshStrobl accepted this revision.Jul 9 2021, 5:42 AM
JoshStrobl added a subscriber: JoshStrobl.

Shit happens, don't worry about it. Patch LGTM :)

This revision is now accepted and ready to land.Jul 9 2021, 5:42 AM
This revision was automatically updated to reflect the committed changes.