Paths

Table of Contentst

Differential D11427

Fix path to executable in sunshine.service
ClosedPublic
Actions

Authored by Jacek on Jul 8 2021, 8:23 PM.

Tags

None

Referenced Files

	F11070945: D11427.diff
	Sat, Aug 12, 12:48 AM

	F10975733: D11427.id27631.diff
	Sat, Jul 22, 6:29 AM

	F10829241: D11427.id27635.diff
	Jun 4 2023, 11:34 AM

	F10820107: D11427.id.diff
	Jun 2 2023, 1:17 AM

	F10799082: D11427.id27631.diff
	May 28 2023, 12:49 PM

	F10797992: D11427.diff
	May 28 2023, 7:51 AM

	F10781816: D11427.id.diff
	May 25 2023, 10:05 AM

	F10688911: D11427.id27635.diff
	Apr 19 2023, 7:38 PM

Subscribers

Details

Reviewers

Group Reviewers

Commits

R5262:41184222ebd9: Fix path to executable in sunshine.service

Summary

Add -D SUNSHINE_EXECUTABLE_PATH=/usr/bin/sunshine to fix path to executable in sunshine.service

Test Plan

Enabled sunshine service successfully
Tested basic sunshine functionality works again

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Jacek created this revision.Jul 8 2021, 8:23 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptJul 8 2021, 8:23 PM

Harbormaster completed remote builds in B1028: Diff 27631.Jul 8 2021, 8:23 PM

Jacek requested review of this revision.Jul 8 2021, 8:23 PM

I'm really sorry I missed that previously, even though I used sunshine for quite a while I haven't used all its features. So recently I have been going through and checking all of them and it turns out I never checked if Systemd service works. Turns out it didn't, and it expected binary in /home/build/YPKG/root/sunshine/build/sunshine.git/build/sunshine.
So if you wanted to make Sunshine run on each boot, it would fail. No other functionality was affected. Sorry I discovered it so late, after the original diff was already accepted.

Shit happens, don't worry about it. Patch LGTM :)

This revision is now accepted and ready to land.Jul 9 2021, 5:42 AM

Closed by commit R5262:41184222ebd9: Fix path to executable in sunshine.service (authored by Jacek, committed by JoshStrobl). · Explain WhyJul 9 2021, 5:42 AM

This revision was automatically updated to reflect the committed changes.

JoshStrobl added a commit: R5262:41184222ebd9: Fix path to executable in sunshine.service.

Revision Contents
Changeset List

Path

Size

4 lines

pspec_x86_64.xml

2 lines

Diff 27635

package.yml

Loading...

pspec_x86_64.xml

Loading...