Initial inclusion of Sunshine, fixes T9799.
Details
Details
- Reviewers
joebonrichie JoshStrobl - Group Reviewers
Triage Team - Maniphest Tasks
- T9799: Sunshine - Moonlight host for game streaming to almost any device.
- Commits
- R5262:68657150b221: Initial inclusion of Sunshine for T9799
Used prebuild Sunshine on both Linux and Windows for last few months.
Used this packaged version for a day with bot PS Vita and Android.
Test on another machine that adding user to input in fact isn't necessary for the controller to work.
Diff Detail
Diff Detail
- Repository
- R5262 sunshine
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
After installation user needs to be added to input group using sudo usermod -a -G input $USER for controller to work. Can it be done during the installation?
AFAIK the only way to add the user to the correct group is with a custom usysconf trigger. We are still using the legacy usysconf, but with the new version of usysconf it should be significantly easier to add a toml based usysconf trigger for this, ping @JoshStrobl for status/thoughts?
I think there is a risk updating the package could overwrite user settings, like in apps_linux.json, but I don't see a better option to package it
I haven't looked deeply into it but upstream should probably generate and install config files to XDG_CONFIG_HOME/sunshine. It might be possible to patch in support for a statelessness config, where /etc/sunshine/apps_linux.json is searched first before /usr/share/sunshine/apps_linux.json. If that's too much work then just leave as-is.
Am I putting all the files in the correct locations, or should I choose some different ones.
File locations look correct to me AFAICT.
make will fail if I don't build in /build, I already mentioned this bug to the author
This is quite common for cmake based projects and is generally recommended behavior, no need to worry about it.
Might have missed some things, the main blocker is the custom post-install step
| package.yml | ||
|---|---|---|
| 2 | Lowercase sunshine | |
| 7 | Should either be GPL-3-0-only or GPL-3.0-or-later, it's hard to tell which one it is as they do not include the copyright notice at the top of their source files. | |
| 8 | Probably network.web is the best component match. | |
| 31 | Using cp is okay here as long as the file permissions are all correct. | |
Comment Actions
I tested it on a fresh machine, and contrary to what program's readme says, you don't need to add user to input group! I even tested it a few months ago and back then it was needed but for some reason it no longer is.
So I think this package is now ready to be included, and all functions work without the need of qol-assist.
Should I create a new diff without [RFC] in the name, or can I just edit this one?
Comment Actions
Fix permissions for sunshine.conf and apps_linux.json, so the new web GUI can edit them