Differential D11323

Update kid3 to 3.8.7
ClosedPublic
Actions

Authored by Harvey on Jun 21 2021, 12:08 PM.

Tags

None

Referenced Files

	F11069273: D11323.id27332.diff
	Fri, Aug 11, 10:37 PM

	F11069272: D11323.id27410.diff
	Fri, Aug 11, 10:37 PM

	F11069271: D11323.id.diff
	Fri, Aug 11, 10:37 PM

	F11069270: D11323.id27405.diff
	Fri, Aug 11, 10:37 PM

	F11050993: D11323.diff
	Thu, Aug 10, 7:41 PM

	F11044682: D11323.diff
	Thu, Aug 10, 10:27 AM

	F10858797: D11323.id27332.diff
	Jun 15 2023, 7:15 PM

	F10858388: D11323.id27405.diff
	Jun 15 2023, 3:03 PM

View All 13 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

R3400:ffb6347b6ab6: Update kid3 to 3.8.7

Summary

New
- Russian handbook.
Fixed
- ID3v2 Wrong numeric strings for genres Fast Fusion, Fok, Folk Rock, Folklore, Funk, Fusion.
- Memory leak in the rare case where the file type is detected not by the extension but by the contents.
- kid3-cli Fields with a non-string value cannot be set with id3lib.

Test Plan

Change metadata for mp3 and mp4 files via cli and GUI

Diff Detail

Repository

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 847
Build 847: arc lint + arc unit

Event Timeline

Harvey created this revision.Jun 21 2021, 12:08 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptJun 21 2021, 12:08 PM

Harvey requested review of this revision.Jun 21 2021, 12:08 PM

Harbormaster completed remote builds in B847: Diff 27332.Jun 21 2021, 12:08 PM

JoshStrobl requested changes to this revision.Jun 22 2021, 5:49 PM

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

pspec_x86_64.xml
92	We should separate out /usr/share/man//man1/kid3-cli into kid3-cli and /usr/share/man//man1/kid3-qt into kid3-qt

This revision now requires changes to proceed.Jun 22 2021, 5:49 PM

Move files into correct package

Harbormaster completed remote builds in B874: Diff 27405.Jun 23 2021, 1:22 AM

LGTM, thanks!

This revision is now accepted and ready to land.Jun 23 2021, 11:39 AM

Closed by commit R3400:ffb6347b6ab6: Update kid3 to 3.8.7 (authored by Harvey, committed by JoshStrobl). · Explain WhyJun 23 2021, 11:40 AM

This revision was automatically updated to reflect the committed changes.

JoshStrobl added a commit: R3400:ffb6347b6ab6: Update kid3 to 3.8.7.

Revision Contents
Changeset List

Path

Size

abi_used_symbols

6 lines

6 lines

pspec_x86_64.xml

14 lines

Diff 27332

abi_used_symbols

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...