Page MenuHomeSolus

fceux: Update to 2.4.0
ClosedPublic

Authored by ReillyBrogan on Jun 12 2021, 7:43 PM.

Details

Summary

Release notes:

Depends on D11266

Test Plan
  • Mapped a gamepad
  • Played SMB3 for a bit
  • Wondered where my SMB3 skill went

Diff Detail

Repository
R736 fceux
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ReillyBrogan created this revision.Jun 12 2021, 7:43 PM
ReillyBrogan requested review of this revision.Jun 12 2021, 7:43 PM
ReillyBrogan edited the summary of this revision. (Show Details)Jun 12 2021, 7:45 PM

Could you please add this patch so we can have fceux with the system icon theme?

--- a/fceux.desktop
+++ b/fceux.desktop
@@ -6,7 +6,7 @@ GenericName=NES/Famicom emulator
 NoDisplay=false
 Comment=Emulate NES ROMs
 Exec=/usr/bin/fceux
-Icon=/usr/share/pixmaps/fceux1.png
+Icon=fceux
 Terminal=false
 MimeType=application/x-nes-rom
 Categories=Game;Emulator;
  • Make fceux work with icon themes
  • Rebuild for accurate ABI report
ReillyBrogan planned changes to this revision.Jun 28 2021, 10:49 PM
  • fceux 2.4.0
ReillyBrogan retitled this revision from fceux: Update to 2.3.0 to fceux: Update to 2.4.0.Jun 30 2021, 6:52 AM
ReillyBrogan edited the summary of this revision. (Show Details)
JoshStrobl accepted this revision.Jul 9 2021, 5:51 AM
JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks!

This revision is now accepted and ready to land.Jul 9 2021, 5:51 AM
JoshStrobl requested changes to this revision.Jul 9 2021, 6:02 AM

Correction, needs to be rebased.

This revision now requires changes to proceed.Jul 9 2021, 6:02 AM
JoshStrobl accepted this revision.Jul 16 2021, 10:04 AM

Thanks!

This revision is now accepted and ready to land.Jul 16 2021, 10:04 AM
This revision was automatically updated to reflect the committed changes.