Page MenuHomeSolus

initial commit of lib2geom
ClosedPublic

Authored by Girtablulu on Jun 12 2021, 4:30 PM.
Tags
None
Referenced Files
F11034182: D11265.id.diff
Wed, Aug 9, 4:30 PM
F11034181: D11265.id27187.diff
Wed, Aug 9, 4:30 PM
F11034180: D11265.id27335.diff
Wed, Aug 9, 4:30 PM
F11034179: D11265.id27203.diff
Wed, Aug 9, 4:30 PM
F11034178: D11265.id27290.diff
Wed, Aug 9, 4:30 PM
F11026370: D11265.diff
Wed, Aug 9, 2:14 AM
F10834144: D11265.id27203.diff
Jun 7 2023, 6:50 AM
F10809150: D11265.id27335.diff
May 30 2023, 12:10 PM
Subscribers

Details

Summary

initial commit of lib2geom

Test Plan

build inkscape against to drop the 3rd party build

Diff Detail

Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 709
Build 709: arc lint + arc unit

Event Timeline

YakoYakoYokuYoku added inline comments.
abi_libs
1

There's no versioned library for this, only the SONAME, you may need to change the lines in [src/2geom/CMakeLists.txt](https://gitlab.com/inkscape/lib2geom/-/blob/1.1/src/2geom/CMakeLists.txt#L183) to this:

     )
 
-set_target_properties(2geom PROPERTIES SOVERSION "${2GEOM_ABI_VERSION}")
+set_target_properties(2geom PROPERTIES SOVERSION "${2GEOM_MAJOR_VERSION}")
+set_target_properties(2geom PROPERTIES VERSION "${2GEOM_ABI_VERSION}")
 
 install(TARGETS 2geom
package.yml
27

I see no need to not to split devel, as this package looks like is not a header-only library.

This revision now requires changes to proceed.Jun 13 2021, 7:26 AM

Rebuild against tooling update

This revision is now accepted and ready to land.Jun 21 2021, 11:35 AM
This revision was automatically updated to reflect the committed changes.