Page MenuHomeSolus

initial commit of lib2geom
ClosedPublic

Authored by Girtablulu on Jun 12 2021, 4:30 PM.

Details

Summary

initial commit of lib2geom

Test Plan

build inkscape against to drop the 3rd party build

Diff Detail

Repository
R5251 lib2geom
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Girtablulu created this revision.Jun 12 2021, 4:30 PM
Girtablulu requested review of this revision.Jun 12 2021, 4:30 PM
YakoYakoYokuYoku added inline comments.
abi_libs
2

There's no versioned library for this, only the SONAME, you may need to change the lines in src/2geom/CMakeLists.txt to this:

     )
 
-set_target_properties(2geom PROPERTIES SOVERSION "${2GEOM_ABI_VERSION}")
+set_target_properties(2geom PROPERTIES SOVERSION "${2GEOM_MAJOR_VERSION}")
+set_target_properties(2geom PROPERTIES VERSION "${2GEOM_ABI_VERSION}")
 
 install(TARGETS 2geom
package.yml
28

I see no need to not to split devel, as this package looks like is not a header-only library.

JoshStrobl requested changes to this revision.Jun 13 2021, 7:26 AM
This revision now requires changes to proceed.Jun 13 2021, 7:26 AM
Girtablulu updated this revision to Diff 27290.Jun 19 2021, 9:44 AM

Rebuild against tooling update

JoshStrobl accepted this revision.Jun 21 2021, 11:35 AM

LGTM, thanks!

This revision is now accepted and ready to land.Jun 21 2021, 11:35 AM
This revision was automatically updated to reflect the committed changes.