Page MenuHomeSolus

Update Inkscape to 1.1
ClosedPublic

Authored by Girtablulu on Jun 3 2021, 9:23 PM.

Details

Summary

Update Inkscape to 1.1
Depends on D11265

Changelog available here

Test Plan

Changed some svg files, and exported them as jpg

Diff Detail

Repository
R1470 inkscape
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 711
Build 711: arc lint + arc unit

Event Timeline

Girtablulu created this revision.Jun 3 2021, 9:23 PM
Girtablulu requested review of this revision.Jun 3 2021, 9:23 PM

Wanna know if I should activate more stuff like any of these

WITH_GNU_READLINE:       OFF
WITH_DBUS:               OFF
WITH_IMAGE_MAGICK:       OFF
WITH_GRAPHICS_MAGICK:    OFF
WITH_LIBCDR:             OFF
WITH_LIBVISIO:           OFF
WITH_LIBWPG:             OFF
WITH_JEMALLOC:           OFF
algent added a subscriber: algent.EditedJun 3 2021, 9:52 PM

There isn't any /usr/share/doc folder in the pspec_x86_64.xml file, so it can be removed from patterns.

Yes -> enable plz

WITH_GNU_READLINE: OFF

Yes

WITH_DBUS: OFF

Yes

WITH_IMAGE_MAGICK: OFF

Yes

WITH_GRAPHICS_MAGICK: OFF

No

WITH_LIBCDR: OFF

Yes

WITH_LIBVISIO: OFF

Yes

WITH_LIBWPG: OFF

Probably not.

WITH_JEMALLOC: OFF

I've seen a hit-and-miss of results with segfaults when enabling this, let's keep this off.

Girtablulu updated this revision to Diff 27087.Jun 4 2021, 9:26 AM

Actiavte things

  • our imagemagic is to new
  • readline support just doesn't want to work, even updating doesnt help (which should be done but needs a full stack rebuild due abi version change)
JoshStrobl requested changes to this revision.Jun 9 2021, 2:13 PM
JoshStrobl added inline comments.
pspec_x86_64.xml
28

lib2geom should be packaged separately: https://gitlab.com/inkscape/lib2geom

78–79

Can be deleted

2525

Can be deleted

2925

Can be deleted

This revision now requires changes to proceed.Jun 9 2021, 2:13 PM
Girtablulu updated this revision to Diff 27188.Jun 12 2021, 4:31 PM

drop 3rd party build of lib2geom by providing a repo package and remove unneeded files

Girtablulu marked 4 inline comments as done.Jun 12 2021, 4:33 PM
Girtablulu updated this revision to Diff 27189.Jun 12 2021, 4:34 PM
Girtablulu edited the summary of this revision. (Show Details)

update summary

Girtablulu updated this revision to Diff 27204.Jun 13 2021, 9:27 AM

build against changes

Girtablulu updated this revision to Diff 27291.Jun 19 2021, 9:55 AM

rebuild agaisnt new tooling

JoshStrobl requested changes to this revision.Jun 21 2021, 11:36 AM
JoshStrobl added inline comments.
package.yml
31

They provide a pkgconfig, you should use it.

This revision now requires changes to proceed.Jun 21 2021, 11:36 AM
Girtablulu updated this revision to Diff 27333.Jun 21 2021, 2:27 PM

forgot to switch to pkgconfig

JoshStrobl accepted this revision.Jun 21 2021, 4:30 PM

LGTM, thanks!

This revision is now accepted and ready to land.Jun 21 2021, 4:30 PM
This revision was automatically updated to reflect the committed changes.