The inclusion of Ganttproject fixes T947
Ganttproject is a Java based project management and scheduling tool
Networking is enabled as during the build process gradle downloads the required dependencies
Details
Details
- Reviewers
joebonrichie - Group Reviewers
Triage Team - Maniphest Tasks
- T947: GanttProject
After installation ganttproject.desktop will be installed in /usr/share/applications. An entry in the desktop environment applications menu will
allow for the program to be launched
Diff Detail
Diff Detail
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| package.yml | ||
|---|---|---|
| 21–24 | I don't like this, you can instead change the source to build from git if it removes the need for this e.g. | |
| 30 | You can use install -dm755 instead and remove the need for line 36 | |
| 36 | This should be an install command | |
| 37 | Not necessary if the change at line 29 is implemented. | |
| 38 | Nitpick, but can this just be -Dm644 | |
| package.yml | ||
|---|---|---|
| 30 | @joebonrichie Please use 5 octal 00755 with install. The extra 00 does make a difference. Ditto for below (00644) | |
Comment Actions
As per review comments:
Modify build to use github source
Moved some commands to 'install' section
Kept 5 octal file permissions as per @sunnyflunk's suggestion
| files/ganttproject.desktop | ||
|---|---|---|
| 6 | You need to install the icon file to /usr/share/pixmaps/ganttproject.svg and this line can just be Icon=ganttproject, if the project provides a .png file that would be more preferable though. | |
| files/ganttproject.desktop | ||
|---|---|---|
| 6 | Apologies, because it is a svg file it needs to be installed to /usr/share/icons/hicolor/scalable/apps/ganttproject.svg | |
Comment Actions
Hey @JoshStrobl, mate I totally forgot about this. I got swamped at work around the time of the comment and it just fell under the radar. It is almost done. If I address the comment can we resurrect this from abandoned?
Cheers,
Ben