Page MenuHomeSolus

Update to 1.8.7 and enable updates
ClosedPublic

Authored by FriesischScott on May 28 2021, 12:01 PM.

Details

Summary

Along with updating to 1.8.7 this enables the auto update feature. New updates will be installed to the users home directory. The launcher protonmail-bridge determines whether to run the default proton-bridge or a newer version if present. In the future this will allow hotfix releases such as 1.8.1 and 1.8.2 to be delivered to the users much faster. Additionally, users can now update to early access releases if they wish to.

Summarized changelog:

  • 1.8.7
    • Updated golang Secure Remote Password Protocol
    • Updated crypto-libraries to gopenpgp/v2 v2.1.10
    • Improved parsing of message headers
    • Sync and performance improvements
  • 1.8.3
    • Fixed a bug with sending encrypted emails to external contacts
  • 1.8.2
    • Hotfix for error during bug reporting
  • 1.8.1
    • Hotfix for crash when listing empty folder
  • 1.8.0
    • Refactor of message builder to achieve greater RFC compliance
    • Implemented connection manager to improve performance during weak connection, better handling of connection loss and other connectivity issues
    • Increased the number of message fetchers to allow more parallel requests - performance improvement
    • Log changes for easier debugging (update-related)
    • Fixed bugs with building of message bodies/headers
    • Fixed incorrect naming format of some of the attachments
    • Removed html-wrapping of non-decriptable messages - to facilitate decryption outside Bridge and/or allow to store such messages as they are

Full changelog: https://protonmail.com/download/bridge/stable_releases.html

Test Plan

Synced and sent mail through Thunderbird successfully.

Successfully used the update feature to update to early access and downgrade to 1.8.7 again.

Diff Detail

Repository
R5138 protonmail-bridge
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

FriesischScott requested review of this revision.May 28 2021, 12:01 PM
FriesischScott edited the summary of this revision. (Show Details)May 28 2021, 12:02 PM
JoshStrobl requested changes to this revision.May 28 2021, 12:57 PM
JoshStrobl added a subscriber: JoshStrobl.

Enabling auto-updates is not acceptable and may result in broken packages or changes that Solus does not want to apply. Needs to be disabled.

This revision now requires changes to proceed.May 28 2021, 12:57 PM

No problem. From the discussion in D10644 I got the impression this was OK. I'll disable the updater.

It's a bit annoying though, that the app has lots of buttons and settings related to updated, early access, etc that don't do anything.

I'll have a look, maybe I can somehow disable/patch out the update related options.

Ah wasn't aware of that patch and the comment:

Normally, we would try to disable the automatic updater, but the signing process won't allow us to do it that way.

Gonna get up to speed on it. No need to make any changes yet.

Thanks. All that signing stuff is beyond me, so just let me know what you decide and I will adapt accordingly.

Hey, sorry for the delay. Let's get this update to 1.8.7 and should be good to go to be landed.

Update to latest version 1.8.7

FriesischScott edited the summary of this revision. (Show Details)Mon, Sep 6, 11:54 PM
FriesischScott edited the test plan for this revision. (Show Details)
FriesischScott retitled this revision from Update to 1.8.3 and enable updates to Update to 1.8.7 and enable updates.
JoshStrobl accepted this revision.Fri, Sep 10, 9:37 PM

LGTM, thanks!

This revision is now accepted and ready to land.Fri, Sep 10, 9:37 PM
JoshStrobl requested changes to this revision.Fri, Sep 10, 9:39 PM

Erm this needs to be rebased.

This revision now requires changes to proceed.Fri, Sep 10, 9:39 PM

Rebase on master

FriesischScott added a comment.EditedSat, Sep 11, 5:41 PM

Erm this needs to be rebased.

Sorry about that. Hope it's correct now.

algent added a subscriber: algent.Sat, Sep 11, 6:17 PM

Sorry about that. Hope it's correct now.

No it is not. The release number should be 7.

Fix release number

JoshStrobl accepted this revision.Wed, Sep 15, 3:15 PM

LGTM, thanks!

This revision is now accepted and ready to land.Wed, Sep 15, 3:15 PM
This revision was automatically updated to reflect the committed changes.