Page MenuHomeSolus

Update xprop to 1.2.5

Authored by Staudey on Sun, May 23, 11:57 PM.



Update xprop to 1.2.5


  • Support true color output for icons if the terminal advertises it
  • Add missing -help function
  • Don't display icons if they would line-wrap
  • Make output with unknown width terminal the same as old code
  • Free string list returned from XmbTextPropertyToTextList
  • Correct icon buffer width computation for truecolor terminals
  • Check return value from ioctl(TIOCGWINSZ)
  • Break down memory allocation logic and fix overallocating for UTF8
  • Fix aspect ratio for icon display by using two characters per icon pixel
  • Fix formatting of back-to-back not shown icons
Test Plan

Checked out the properties of various windwos/apps, used the -help option

Diff Detail

R3275 xprop
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Staudey created this revision.Sun, May 23, 11:57 PM
Staudey requested review of this revision.Sun, May 23, 11:57 PM
JoshStrobl accepted this revision.Wed, May 26, 8:12 AM
JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks!

This revision is now accepted and ready to land.Wed, May 26, 8:12 AM
This revision was automatically updated to reflect the committed changes.