spice-gtk: set suid bit on usb redirection helper, fixes T9734
ClosedPublic
Actions

Authored by be1 on May 21 2021, 2:29 PM.

Details

Reviewers

DataDrake

Group Reviewers

Triage Team

Maniphest Tasks

T9734: spice-gtk: USB redirection error

Commits

R2947:3ebf93c3ff96: spice-gtk: set suid bit on usb redirection helper, fixes T9734

Summary

setting suid bit on USB redirection helper allow to share an usb device to the guest host. This patch fixes T9734.

Test Plan

open gnome-boxes or any other front-end software that uses spice-gtk, configure a guest OS, start it.
In the settings of the guest, share an USB device.
No error should happen anymore. (But sometimes gnome-boxes segfaults for other reasons)

Diff Detail

Repository

R2947 spice-gtk

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

be1 created this revision.May 21 2021, 2:29 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptMay 21 2021, 2:29 PM

be1 requested review of this revision.May 21 2021, 2:29 PM

Harbormaster completed remote builds in B487: Diff 26849.May 21 2021, 2:29 PM

You didn't bump the package release number.
Do make bump
make
make clean
Amend the changes and resubmit the diff.

Added suid bit on USB redirection helper
Bumped package release number

Harbormaster completed remote builds in B488: Diff 26850.May 21 2021, 3:20 PM

be1 edited the summary of this revision. (Show Details)May 21 2021, 3:26 PM

be1 edited the test plan for this revision. (Show Details)

be1 added a task: T9734: spice-gtk: USB redirection error.

be1 retitled this revision from set suid bit on usb redirection helper, fixes T9734 to spice-gtk: set suid bit on usb redirection helper, fixes T9734.

ReillyBrogan added a subscriber: ReillyBrogan.May 24 2021, 1:43 AM