Page MenuHomeSolus

Even more plugins for gstreamer-1.0-plugins-bad
ClosedPublic

Authored by YakoYakoYokuYoku on May 20 2021, 11:15 PM.
Tags
None
Referenced Files
F11050100: D11135.id26839.diff
Thu, Aug 10, 6:45 PM
F11050098: D11135.id26840.diff
Thu, Aug 10, 6:45 PM
F11050093: D11135.id27075.diff
Thu, Aug 10, 6:45 PM
F11050092: D11135.id26848.diff
Thu, Aug 10, 6:45 PM
F11050090: D11135.id26922.diff
Thu, Aug 10, 6:45 PM
F11050089: D11135.id26911.diff
Thu, Aug 10, 6:45 PM
F11050088: D11135.id.diff
Thu, Aug 10, 6:44 PM
F11050086: D11135.id28394.diff
Thu, Aug 10, 6:44 PM
Subscribers

Details

Summary

Packaging changes:

  • Included plugins:
    • OpenAL
    • OpenCV
    • Vulkan

Depends on D11129, D11132 and D11702.

Signed-off-by: Martin Reboredo <yakoyoku@gmail.com>

Test Plan

Launched separate pipelines with the av1enc, mpeg2enc, libde265, vulkanupload (w/ friends), frei0r-filter-sobel, cameracalibrate and cvsobel plugins.

Diff Detail

Repository
R1085 gstreamer-1.0-plugins-bad
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

JoshStrobl added a subscriber: JoshStrobl.

Why do we need Neon support? Who uses this?

This revision now requires changes to proceed.May 21 2021, 8:14 AM
YakoYakoYokuYoku edited the summary of this revision. (Show Details)
YakoYakoYokuYoku edited the test plan for this revision. (Show Details)

Remove neonhttpsrc plugin.

Why do we need Neon support? Who uses this?

It's a plugin that has only HTTP capabilities, I thought that it had further WebDAV support, but it's just an older alternative to the much preferable souphttpsrc.

YakoYakoYokuYoku edited the test plan for this revision. (Show Details)

Included aom av1enc fixup.

JoshStrobl added inline comments.
package.yml
78

Eh? Surely you should be splitting out the opencv headers and having the opencv gst package + devel require bad, not the other way around.

This revision now requires changes to proceed.May 26 2021, 6:55 AM
YakoYakoYokuYoku edited the summary of this revision. (Show Details)
YakoYakoYokuYoku edited the test plan for this revision. (Show Details)

Incorporate WPE (wpesrc) plugin.

Why are we enabling the WPE plugin? What is going to leverage this?

This revision now requires changes to proceed.May 27 2021, 8:31 AM

The plugin provides a video/audio source from rendered webpages, much like the OBS Browser Source plugin but for GStreamer.

The plugin provides a video/audio source from rendered webpages, much like the OBS Browser Source plugin but for GStreamer.

Okay but what uses this? If nothing uses it then why would we enable it?

Okay but what uses this? If nothing uses it then why would we enable it?

Nothing atm depends on it, but the plugin has use cases/features for it like webpage video overlays or OpenGL rendering.

In that case, please remove it. We can add it when it is necessary to do so. We don't arbitrarily enable features just to enable features.

YakoYakoYokuYoku edited the summary of this revision. (Show Details)

Remove dependency on WPEWebkit.

JoshStrobl added inline comments.
package.yml
14

This can just be - ^gstreamer-1.0-plugins-opencv : OpenCV GStreamer plugins and you need to give the same treatment to description, e.g.

description :
     - GStreamer is a streaming media framework, based on graphs of elements which operate on media data. This package contains plug-ins that aren't tested well enough, or the code is not of good enough quality.
     - ^gstreamer-1.0-plugins-opencv : OpenCV GStreamer plugins
     - ^gstreamer-1.0-plugins-opencv-devel : Development files for gstreamer-1.0-plugins-opencv
This revision now requires changes to proceed.Jun 3 2021, 3:21 PM
This revision is now accepted and ready to land.Jun 3 2021, 4:37 PM
YakoYakoYokuYoku edited the summary of this revision. (Show Details)
YakoYakoYokuYoku edited the test plan for this revision. (Show Details)

Rebase against libde265 update.