Page MenuHomeSolus

Update retroarch to 1.9.4
Changes PlannedPublic

Authored by ReillyBrogan on May 20 2021, 4:30 AM.


Group Reviewers
Triage Team

Release notes available here

Test Plan

Loaded up Metroid Fusion and played for a bit. Mapped an 8bitdo Pro 2 and played with that.

Diff Detail

R2809 retroarch
No Linters Available
No Unit Test Coverage
Build Status
Buildable 672
Build 672: arc lint + arc unit

Event Timeline

ReillyBrogan created this revision.May 20 2021, 4:30 AM
ReillyBrogan requested review of this revision.May 20 2021, 4:30 AM
Jacalz added a subscriber: Jacalz.May 20 2021, 6:31 AM

Please update the file as well. I have stepped down as a maintainer, so I will not update it anytime soon and you could thus take over the maintainership if you want. Keep in mind that you would not have been allowed to land this update unless that was the case. The file usually forbids other people to land patches for the packages.

Hi @Jacalz! I have already updated the to reflect that you stepped down. I wouldn't have submitted the patch in the first place had you not done so.

I'm not currently interested in becoming the dedicated maintainer of this package, but might step up if no-one else does so.

Forgot to bump package version

JoshStrobl requested changes to this revision.May 20 2021, 7:01 AM
JoshStrobl added a subscriber: JoshStrobl.

Need a maintainer.

This revision now requires changes to proceed.May 20 2021, 7:01 AM
  • Add
  • Set a few default settings
  • Create new assets subpackage
  • Disable a few built-in libraries and use shared system ones instead
ReillyBrogan retitled this revision from Update retroarch to 1.9.3 to Update retroarch to 1.9.4.Sat, Jun 5, 8:47 PM
ReillyBrogan edited the summary of this revision. (Show Details)
JoshStrobl requested changes to this revision.Wed, Jun 9, 4:15 PM
JoshStrobl added inline comments.

We should be choosing whatever works best for the user not forcing vulkan.


What is the point in splitting this if you're just going to require that retroarch depends on the assets sub-package? Just bundle them in the main package.

This revision now requires changes to proceed.Wed, Jun 9, 4:15 PM
  • Bundle assets in main package instead of creating a subpackage
  • Figured out a more concise and less likely way to patch configuration.c
  • Removed vulkan as default (the default is now openGL)
ReillyBrogan marked 2 inline comments as done.Thu, Jun 10, 5:46 AM
ReillyBrogan added inline comments.

It wasn't forcing vulkan. It was choosing it as the default on first launch for any user launching Retroarch for the first time (or who had deleted their ~/.config/retroarch/retroarch.cfg for some reason). Any pre-existing users would keep their existing settings and any user would be free to change to one of the other drivers if that one served their needs better.

My research (and testing confirmed) showed that Vulkan is considered stable and well-supported for all software-rendered cores (which is almost all of them) but upon reflection I think OpenGL is the saner default.

ReillyBrogan planned changes to this revision.Mon, Jun 14, 7:13 PM
ReillyBrogan marked an inline comment as done.
  • Retroarch v1.9.5