Page MenuHomeSolus
Differential D11128

Update retroarch to 1.9.6
ClosedPublic
Actions

Authored by ReillyBrogan on May 20 2021, 4:30 AM.
Tags
None
Referenced Files
F11018782: D11128.id27663.diff
Sun, Aug 6, 2:48 PM
F10906662: D11128.id27822.diff
Jul 6 2023, 12:47 PM
F10896288: D11128.diff
Jul 1 2023, 11:09 PM
F10858381: D11128.diff
Jun 15 2023, 3:02 PM
F10857203: D11128.diff
Jun 15 2023, 3:47 AM
F10851752: D11128.id27103.diff
Jun 12 2023, 4:00 PM
F10844313: D11128.id27663.diff
Jun 10 2023, 8:39 PM
F10843665: D11128.id26817.diff
Jun 10 2023, 6:49 PM
View All 25 Files
Subscribers
Jacalz
JoshStrobl
Lonsfor

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Commits
R2809:2a13f6c4378c: Update retroarch to 1.9.6
Summary

Release notes available here

Test Plan

Loaded up Metroid Fusion and played for a bit. Mapped an 8bitdo Pro 2 and played with that.

Diff Detail

Repository
R2809 retroarch
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ReillyBrogan created this revision.May 20 2021, 4:30 AM
Herald added a reviewer: Triage Team. · View Herald TranscriptMay 20 2021, 4:30 AM
Harbormaster completed remote builds in B469: Diff 26816.May 20 2021, 4:30 AM
ReillyBrogan requested review of this revision.May 20 2021, 4:30 AM
Jacalz added a subscriber: Jacalz.May 20 2021, 6:31 AM

Please update the MAINTAINERS.md file as well. I have stepped down as a maintainer, so I will not update it anytime soon and you could thus take over the maintainership if you want. Keep in mind that you would not have been allowed to land this update unless that was the case. The MAINTAINERS.md file usually forbids other people to land patches for the packages.

ReillyBrogan added a comment.May 20 2021, 6:42 AM

Hi @Jacalz! I have already updated the MAINTAINERS.md to reflect that you stepped down. I wouldn't have submitted the patch in the first place had you not done so.

I'm not currently interested in becoming the dedicated maintainer of this package, but might step up if no-one else does so.

ReillyBrogan updated this revision to Diff 26817.May 20 2021, 6:44 AM

Forgot to bump package version

Harbormaster completed remote builds in B470: Diff 26817.May 20 2021, 6:44 AM
JoshStrobl requested changes to this revision.May 20 2021, 7:01 AM
JoshStrobl added a subscriber: JoshStrobl.

Need a maintainer.

This revision now requires changes to proceed.May 20 2021, 7:01 AM
ReillyBrogan updated this revision to Diff 27103.Jun 5 2021, 8:47 PM
  • Add maintainers.md
  • Set a few default settings
  • Create new assets subpackage
  • Disable a few built-in libraries and use shared system ones instead
Harbormaster completed remote builds in B647: Diff 27103.Jun 5 2021, 8:47 PM
ReillyBrogan retitled this revision from Update retroarch to 1.9.3 to Update retroarch to 1.9.4.Jun 5 2021, 8:47 PM
ReillyBrogan edited the summary of this revision. (Show Details)
JoshStrobl requested changes to this revision.Jun 9 2021, 4:15 PM
JoshStrobl added inline comments.
files/0001-Set-Solus-Defaults.patch
194

We should be choosing whatever works best for the user not forcing vulkan.

package.yml
36

What is the point in splitting this if you're just going to require that retroarch depends on the assets sub-package? Just bundle them in the main package.

This revision now requires changes to proceed.Jun 9 2021, 4:15 PM
ReillyBrogan updated this revision to Diff 27143.Jun 10 2021, 5:32 AM
  • Bundle assets in main package instead of creating a subpackage
  • Figured out a more concise and less likely way to patch configuration.c
  • Removed vulkan as default (the default is now openGL)
Harbormaster completed remote builds in B672: Diff 27143.Jun 10 2021, 5:32 AM
ReillyBrogan marked 2 inline comments as done.Jun 10 2021, 5:46 AM
ReillyBrogan added inline comments.
files/0001-Set-Solus-Defaults.patch
194

It wasn't forcing vulkan. It was choosing it as the default on first launch for any user launching Retroarch for the first time (or who had deleted their ~/.config/retroarch/retroarch.cfg for some reason). Any pre-existing users would keep their existing settings and any user would be free to change to one of the other drivers if that one served their needs better.

My research (and testing confirmed) showed that Vulkan is considered stable and well-supported for all software-rendered cores (which is almost all of them) but upon reflection I think OpenGL is the saner default.

ReillyBrogan planned changes to this revision.Jun 14 2021, 7:13 PM
ReillyBrogan marked an inline comment as done.
  • Retroarch v1.9.5
ReillyBrogan updated this revision to Diff 27486.Jun 28 2021, 8:15 AM
  • 1.9.6
Harbormaster completed remote builds in B943: Diff 27486.Jun 28 2021, 8:15 AM
ReillyBrogan retitled this revision from Update retroarch to 1.9.4 to Update retroarch to 1.9.6.Jun 28 2021, 8:15 AM
ReillyBrogan edited the summary of this revision. (Show Details)
JoshStrobl requested changes to this revision.Jun 30 2021, 8:15 AM

Needs to be rebased against R2809:f50f1e13ea3a: Rebuild against toolchain

This revision now requires changes to proceed.Jun 30 2021, 8:15 AM
Lonsfor added a subscriber: Lonsfor.Jul 4 2021, 3:17 AM
ReillyBrogan updated this revision to Diff 27663.Jul 10 2021, 10:30 AM
  • Rebase
Harbormaster completed remote builds in B1039: Diff 27663.Jul 10 2021, 10:30 AM
JoshStrobl accepted this revision.Jul 21 2021, 8:00 PM

LGTM, thanks!

This revision is now accepted and ready to land.Jul 21 2021, 8:00 PM
Closed by commit R2809:2a13f6c4378c: Update retroarch to 1.9.6 (authored by ReillyBrogan, committed by JoshStrobl). · Explain WhyJul 21 2021, 8:00 PM
This revision was automatically updated to reflect the committed changes.
JoshStrobl added a commit: R2809:2a13f6c4378c: Update retroarch to 1.9.6.
JoshStrobl added a comment.Jul 21 2021, 8:08 PM

Build failed, supplemental patch needs to be provided that corrects inaccurate shasum.

Revision Contents
Changeset List

PathSize
5 lines
11 lines
11 lines
8 lines
137 lines
files/
40 lines
31 lines
5021 lines

Diff 27822

View Options

MAINTAINERS.md

Loading...
View Options

abi_libs

Loading...
View Options

abi_symbols

Loading...
View Options

abi_used_libs

Loading...
View Options

abi_used_symbols

Loading...
View Options

files/0001-Set-Solus-Defaults.patch

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.