Page MenuHomeSolus
Differential D11083

Re-enable JACK support in Hydrogen
ClosedPublic
Actions

Authored by Desidiosus on May 15 2021, 11:25 AM.
Tags
None
Referenced Files
F10973921: D11083.id26744.diff
Fri, Jul 21, 10:19 PM
F10944207: D11083.diff
Fri, Jul 14, 10:25 PM
F10943390: D11083.id26744.diff
Fri, Jul 14, 6:10 PM
F10896736: D11083.diff
Jul 2 2023, 2:18 AM
F10876797: D11083.id27418.diff
Jun 20 2023, 1:22 PM
F10873531: D11083.id28444.diff
Jun 19 2023, 2:33 PM
F10873247: D11083.id26744.diff
Jun 19 2023, 10:08 AM
F10872615: D11083.id27007.diff
Jun 19 2023, 1:50 AM
View All 11 Files
Subscribers
DataDrake
JoshStrobl

Details

Reviewers
DataDrake
JoshStrobl
Group Reviewers
Triage Team
Commits
R1436:61f5d520e522: Re-enable JACK support in Hydrogen
Summary
  • Build Hydrogen with JACK support
Test Plan
  • Create a drum pattern and play it using JACK and PulseAudio OK
  • Start playback using a different JACK transport master (QJackCtl) OK
  • Start playback with Hydrogen as JACK transport master OK
  • Save and export OK

Diff Detail

Repository
R1436 hydrogen
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 585
Build 585: arc lint + arc unit

Event Timeline

Desidiosus created this revision.May 15 2021, 11:25 AM
Herald added a reviewer: Triage Team. · View Herald TranscriptMay 15 2021, 11:25 AM
Harbormaster completed remote builds in B406: Diff 26744.May 15 2021, 11:25 AM
Desidiosus requested review of this revision.May 15 2021, 11:25 AM
Desidiosus retitled this revision from Re-enable JACK support in Hydrogen Signed-off-by: Juuso Kaitila <desidiosus@solus.mail.kapsi.fi> to Re-enable JACK support in Hydrogen.May 23 2021, 4:16 PM
DataDrake requested changes to this revision.May 30 2021, 3:38 PM
DataDrake added a subscriber: DataDrake.
DataDrake added inline comments.
pspec_x86_64.xml
532

You bumped the release in the package.yml but didn't rebuild so the pspec is wrong.

This revision now requires changes to proceed.May 30 2021, 3:38 PM
Desidiosus updated this revision to Diff 27007.May 31 2021, 8:27 AM

Add updated pspec and missing abi_ files

Harbormaster completed remote builds in B585: Diff 27007.May 31 2021, 8:27 AM
Desidiosus updated this revision to Diff 27418.Jun 24 2021, 6:10 AM

Rebased changes over toolchain rebuild

Harbormaster completed remote builds in B884: Diff 27418.Jun 24 2021, 6:10 AM
JoshStrobl accepted this revision.Aug 23 2021, 1:09 PM
JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Aug 23 2021, 1:10 PM
Closed by commit R1436:61f5d520e522: Re-enable JACK support in Hydrogen (authored by Juuso Kaitila <desidiosus@solus.mail.kapsi.fi>, committed by JoshStrobl). · Explain Why
This revision was automatically updated to reflect the committed changes.
JoshStrobl added a commit: R1436:61f5d520e522: Re-enable JACK support in Hydrogen.

Revision Contents
Changeset List

PathSize
1 line
208 lines
1 line
1335 lines
3 lines
14 lines

Diff 27007

View Options

abi_libs

Loading...
View Options

abi_symbols

Loading...
View Options

abi_used_libs

Loading...
View Options

abi_used_symbols

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.