Page MenuHomeSolus

Initial commit of lxd
ClosedPublic

Authored by ReillyBrogan on May 13 2021, 4:50 AM.
Tags
None
Referenced Files
F10828582: D11065.id27146.diff
Sun, Jun 4, 9:48 AM
F10820155: D11065.id27912.diff
Fri, Jun 2, 1:31 AM
F10793760: D11065.id27239.diff
Sat, May 27, 12:58 PM
F10760115: D11065.id.diff
Wed, May 17, 11:56 PM
F10743007: D11065.id27907.diff
Sun, May 14, 6:17 PM
F10742914: D11065.id26843.diff
Sun, May 14, 5:54 PM
F10742801: D11065.id27239.diff
Sun, May 14, 5:19 PM
F10742737: D11065.id26643.diff
Sun, May 14, 5:02 PM
Subscribers

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T9715: LXD
Commits
R5274:b71e1418f561: Initial commit of lxd
Summary

Closes T9715

Test Plan

Created a few containers, tested that they functioned

Diff Detail

Branch
main
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 482
Build 482: arc lint + arc unit

Event Timeline

JoshStrobl added a subscriber: JoshStrobl.

Your stack is reversed and needs correcting.

This revision now requires changes to proceed.May 15 2021, 11:54 AM
  • Use tmpfiles to create /var/log/lxd
  • Use install command instead of mkdir for creating the docs folder

Unnecessary quotes are unnecessary.

package.yml
29

Should be using $workdir not PKG_BUILD_DIR

56

Doubtful anyone is going to be reading the shipped docs instead of the up-to-date web documentation. Can be removed.

This revision now requires changes to proceed.May 20 2021, 8:16 AM
  • Unnecessary quotes are unnecessary
  • Change some of the PKB_BUILD_DIR to workdir (except for two that can't be changed)
  • Remove docs
package.yml
51

You don't need to do ${pkgfiles}, it is really only applicable during string interpolation. $pkgfiles works.

  • LXD 4.15
  • Cleanup build script
  • Add setup hints to description to ease the pain for new users (who will likely never read it)
  • Rebuild for accurate ABI report
JoshStrobl added inline comments.
package.yml
14

This shouldn't be in the description. Documentation like this is more appropriate for our Help Center if it is specific to Solus, otherwise folks should read documentation. This isn't a commonly used, "normal user" utility, it is a developer-oriented containerization daemon. I would like to think devs know how to read docs.

43

Unnecessary indentation

44

Unnecessary indentation

This revision now requires changes to proceed.Jun 30 2021, 8:19 AM
This revision is now accepted and ready to land.Jul 21 2021, 3:13 PM

master not main.

This revision now requires changes to proceed.Jul 21 2021, 7:57 PM
This revision is now accepted and ready to land.Jul 27 2021, 4:47 PM
This revision was automatically updated to reflect the committed changes.