Page MenuHomeSolus

Initial commit of lxd
ClosedPublic

Authored by ReillyBrogan on May 13 2021, 4:50 AM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T9715: LXD
Commits
R5274:b71e1418f561: Initial commit of lxd
Summary

Closes T9715

Test Plan

Created a few containers, tested that they functioned

Diff Detail

Repository
R5274 lxd
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ReillyBrogan created this revision.May 13 2021, 4:50 AM
ReillyBrogan requested review of this revision.May 13 2021, 4:50 AM
JoshStrobl requested changes to this revision.May 15 2021, 11:54 AM
JoshStrobl added a subscriber: JoshStrobl.

Your stack is reversed and needs correcting.

This revision now requires changes to proceed.May 15 2021, 11:54 AM
ReillyBrogan planned changes to this revision.May 15 2021, 7:30 PM
  • Use tmpfiles to create /var/log/lxd
  • Use install command instead of mkdir for creating the docs folder
JoshStrobl requested changes to this revision.May 20 2021, 8:16 AM

Unnecessary quotes are unnecessary.

package.yml
29

Should be using $workdir not PKG_BUILD_DIR

56

Doubtful anyone is going to be reading the shipped docs instead of the up-to-date web documentation. Can be removed.

This revision now requires changes to proceed.May 20 2021, 8:16 AM
  • Unnecessary quotes are unnecessary
  • Change some of the PKB_BUILD_DIR to workdir (except for two that can't be changed)
  • Remove docs
ReillyBrogan marked 2 inline comments as done.May 21 2021, 3:00 AM
JoshStrobl added inline comments.May 21 2021, 8:42 AM
package.yml
52

You don't need to do ${pkgfiles}, it is really only applicable during string interpolation. $pkgfiles works.

ReillyBrogan planned changes to this revision.May 25 2021, 2:45 AM
  • LXD 4.15
  • Cleanup build script
  • Add setup hints to description to ease the pain for new users (who will likely never read it)
ReillyBrogan marked an inline comment as done.Jun 10 2021, 7:07 AM
  • Rebuild for accurate ABI report
JoshStrobl requested changes to this revision.Jun 30 2021, 8:19 AM
JoshStrobl added inline comments.
package.yml
14

This shouldn't be in the description. Documentation like this is more appropriate for our Help Center if it is specific to Solus, otherwise folks should read documentation. This isn't a commonly used, "normal user" utility, it is a developer-oriented containerization daemon. I would like to think devs know how to read docs.

43

Unnecessary indentation

44

Unnecessary indentation

This revision now requires changes to proceed.Jun 30 2021, 8:19 AM
  • lxd 4.16
  • Fix feedback
ReillyBrogan marked 3 inline comments as done.Jul 10 2021, 10:28 AM
JoshStrobl accepted this revision.Jul 21 2021, 3:13 PM

LGTM, thanks!

This revision is now accepted and ready to land.Jul 21 2021, 3:13 PM
JoshStrobl requested changes to this revision.Jul 21 2021, 7:57 PM

master not main.

This revision now requires changes to proceed.Jul 21 2021, 7:57 PM
  • master not main
JoshStrobl accepted this revision.Jul 27 2021, 4:47 PM

LGTM, thanks!

This revision is now accepted and ready to land.Jul 27 2021, 4:47 PM
This revision was automatically updated to reflect the committed changes.