Page MenuHomeSolus

Initial commit of lxcfs
ClosedPublic

Authored by ReillyBrogan on May 13 2021, 4:28 AM.

Details

Summary

Part of T9715

Test Plan

Tested with LXD

Diff Detail

Repository
R5271 lxcfs
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ReillyBrogan created this revision.May 13 2021, 4:28 AM
ReillyBrogan requested review of this revision.May 13 2021, 4:28 AM

Add maintainers.md

JoshStrobl requested changes to this revision.May 15 2021, 11:58 AM
JoshStrobl added a subscriber: JoshStrobl.

Your stack is reversed and needs correcting.

package.yml
17

This should be in setup not build.

21

You shouldn't be shipping this, should be a systemd tmpfiles instead. See snapd for an example.

This revision now requires changes to proceed.May 15 2021, 11:58 AM
  • Move configure to setup phase
  • Use systemd tmpfiles instead of creating a directory manually
  • Fix tmpfile
JoshStrobl requested changes to this revision.May 20 2021, 8:07 AM
JoshStrobl added inline comments.
package.yml
23

Doesn't need to be quoted.

This revision now requires changes to proceed.May 20 2021, 8:07 AM
  • Remove quotes per feedback
  • Commonize syntax of install commands
ReillyBrogan marked 3 inline comments as done.May 21 2021, 2:44 AM
JoshStrobl accepted this revision.May 26 2021, 6:56 AM

LGTM, thanks!

This revision is now accepted and ready to land.May 26 2021, 6:56 AM
  • Rebuild for accurate ABI report
JoshStrobl requested changes to this revision.Jul 21 2021, 7:57 PM

This needs to be properly rebased, you are basing this against a non-existent branch. Should be against master.

This revision now requires changes to proceed.Jul 21 2021, 7:57 PM
  • lxcfs 4.0.9
  • Fix branch
JoshStrobl accepted this revision.Jul 27 2021, 4:47 PM

LGTM, thanks!

This revision is now accepted and ready to land.Jul 27 2021, 4:47 PM
This revision was automatically updated to reflect the committed changes.