Page MenuHomeSolus

Initial commit of raft
ClosedPublic

Authored by ReillyBrogan on May 13 2021, 2:25 AM.

Details

Summary

Part of T9715

Test Plan

Used to compile dqlite and lxd

Diff Detail

Repository
R5272 raft
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ReillyBrogan created this revision.May 13 2021, 2:25 AM
ReillyBrogan requested review of this revision.May 13 2021, 2:25 AM

Use programming.library for the component instead of virt

JoshStrobl requested changes to this revision.May 15 2021, 11:59 AM
JoshStrobl added a subscriber: JoshStrobl.

Stack is reversed and needs correcting.

package.yml
7

This is not a SPDX 3.0 identifier.

16

Should be in setup not build.

This revision now requires changes to proceed.May 15 2021, 11:59 AM
  • Use valid SPDX 3.0 identifier
  • Move reconfigure to setup
JoshStrobl requested changes to this revision.May 15 2021, 6:03 PM
JoshStrobl added inline comments.
pspec_x86_64.xml
41

Need to disable static

This revision now requires changes to proceed.May 15 2021, 6:03 PM
ReillyBrogan marked 2 inline comments as done.May 15 2021, 6:11 PM
ReillyBrogan marked an inline comment as done.
  • Disable static lib compilation
JoshStrobl requested changes to this revision.May 20 2021, 8:08 AM
JoshStrobl added inline comments.
package.yml
23

Doesn't need to be quoted. Can just do $installdir/usr/bin

This revision now requires changes to proceed.May 20 2021, 8:08 AM
  • Remove quotes per feedback
ReillyBrogan marked an inline comment as done.May 21 2021, 2:46 AM
JoshStrobl accepted this revision.May 26 2021, 6:57 AM

LGTM, thanks!

This revision is now accepted and ready to land.May 26 2021, 6:57 AM
  • Use raft 0.11.1
JoshStrobl requested changes to this revision.Jul 21 2021, 7:57 PM

Should be against master not main...

This revision now requires changes to proceed.Jul 21 2021, 7:57 PM
  • Switch to master
JoshStrobl accepted this revision.Jul 27 2021, 4:40 PM

LGTM, thanks!

This revision is now accepted and ready to land.Jul 27 2021, 4:40 PM
This revision was automatically updated to reflect the committed changes.