Page MenuHomeSolus

Build qdoc in qt5-tools
ClosedPublic

Authored by livingsilver94 on Sun, May 2, 4:25 PM.

Details

Summary

Build qdoc in qt5-tools. This is needed to make Qt5 examples appear in Qt Creator.

Test Plan

Built qt5-base using this package. qt5-base-docs and qt5-base-demos then allow qtcreator to show examples.

Diff Detail

Repository
R2750 qt5-tools
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

livingsilver94 created this revision.Sun, May 2, 4:25 PM
livingsilver94 requested review of this revision.Sun, May 2, 4:25 PM
livingsilver94 edited the test plan for this revision. (Show Details)Sun, May 2, 4:26 PM
livingsilver94 edited the summary of this revision. (Show Details)
livingsilver94 retitled this revision from Build qtdoc in qt5-tools to Build qdoc in qt5-tools.
Girtablulu requested changes to this revision.Sun, May 2, 4:42 PM
Girtablulu added a subscriber: Girtablulu.
Girtablulu added inline comments.
package.yml
21

if you use the flag

clang : yes

should work as well

This revision now requires changes to proceed.Sun, May 2, 4:42 PM
livingsilver94 added inline comments.Sun, May 2, 4:47 PM
package.yml
21

It's different. By including llvm-clang-devel we use GCC to build the package while allowing qdoc to use clang's parsing functions for its jobs. If we set clang: yes, we're both allowing qdoc to use clang (because we're still including llvm-clang-devel) AND we're building the whole package with clang.

So if you're OK with building qt5-tools with clang, all great, otherwise including llvm-clang-devel is the right choice.

livingsilver94 added inline comments.Sun, May 2, 7:00 PM
package.yml
21

Another solution would be taking out libclang from llvm-clang and putting it into its own package, but that's something Core should decide.

Girtablulu added inline comments.Sun, May 2, 7:21 PM
package.yml
21

no, we will do it your way. lets stay with all qt5 packages using gcc

livingsilver94 requested review of this revision.Mon, May 3, 6:54 AM
Girtablulu accepted this revision.Tue, May 4, 2:31 PM

LGTM, thx

Gonna pull this in after you pused the other packages

This revision is now accepted and ready to land.Tue, May 4, 2:31 PM
This revision was automatically updated to reflect the committed changes.