Page MenuHomeSolus

Initial commit of qt5-remoteobjects
ClosedPublic

Authored by YakoYakoYokuYoku on May 2 2021, 3:23 PM.

Details

Summary

Dependency of PySide2.

Signed-off-by: Martin Reboredo <yakoyoku@gmail.com>

Test Plan

Built against python-pyside2.

Diff Detail

Repository
R5216 qt5-remoteobjects
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

YakoYakoYokuYoku requested review of this revision.May 2 2021, 3:23 PM
Girtablulu requested changes to this revision.May 2 2021, 4:11 PM
Girtablulu added a subscriber: Girtablulu.
Girtablulu added inline comments.
package.yml
6

can you switch it to https://invent.kde.org/qt/qt/qtremoteobjects : 4d6d1e35fb8e0cb900b5e5e9266edea51dc4f735

This revision now requires changes to proceed.May 2 2021, 4:11 PM
YakoYakoYokuYoku marked an inline comment as done.May 2 2021, 6:04 PM
YakoYakoYokuYoku added inline comments.
package.yml
6

In this case I think it's better to use that tarball, as the qtremoteobjects repository doesn't have any remarkable difference between the KDE mirror, but if the KDE source is still needed, I can switch it to the invent.kde.org tarball.

YakoYakoYokuYoku requested review of this revision.May 2 2021, 6:04 PM
YakoYakoYokuYoku marked an inline comment as done.
Girtablulu added inline comments.May 2 2021, 6:36 PM
package.yml
6

no, please use the git source, should I need to add a patch I have to switch to it anyway

YakoYakoYokuYoku marked an inline comment as done.

Use KDE's branch.

Girtablulu resigned from this revision.May 4 2021, 2:54 PM

Split demos into subpackage.

DataDrake accepted this revision.May 14 2021, 1:48 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.May 14 2021, 1:48 PM
This revision was automatically updated to reflect the committed changes.