The GLSL compilation is done by the shaderc library, very useful when using in conjunction with Vulkan
Fixes T9692 too.
Signed-off-by: Martin Reboredo <yakoyoku@gmail.com>
Details
Details
- Reviewers
- None
- Group Reviewers
Triage Team - Maniphest Tasks
- T9692: empty libraries
Played a test video with a shader (mpv --gpu-api=vulkan --glsl-shader=FSRCNNX_x2_8-0-4-1.glsl --spirv-compiler=shaderc drstone1.mp4).
Diff Detail
Diff Detail
- Repository
- R2107 mpv
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 162 Build 162: arc lint + arc unit
Event Timeline
Comment Actions
As I mentioned in #Solus-Dev, this is redundant, since libplacebo-devel depends on shaderc-devel, and the last build of mpv already has this functionality (and pkgconfig(shaderc) is not needed). You can check the build log or rebuild without pkgconfig(shaderc) to be sure :)
Comment Actions
This is the commit that we explicitly mention that mpv is gonna support SPIR-V shaders, but this is top secret and don't tell anybody.
Comment Actions
This isn't necessary and it doesn't fix the issue, because the issue was invalid to begin with. mpv was already rebuild against libplacebo.