Page MenuHomeSolus
Differential D10916

Update mozc to 2.26.4346
ClosedPublic
Actions

Authored by PG_MANA on Apr 25 2021, 11:56 AM.
Tags
None
Referenced Files
F11069732: D10916.diff
Fri, Aug 11, 11:27 PM
F10935353: D10916.id29002.diff
Jul 12 2023, 8:11 PM
F10906484: D10916.id28546.diff
Jul 6 2023, 10:16 AM
F10843473: D10916.id29003.diff
Jun 10 2023, 6:00 PM
F10841738: D10916.id29000.diff
Jun 10 2023, 8:41 AM
F10841340: D10916.id26307.diff
Jun 10 2023, 6:35 AM
F10840902: D10916.id26737.diff
Jun 10 2023, 3:40 AM
F10839835: D10916.id29004.diff
Jun 9 2023, 10:59 PM
View All 20 Files
Subscribers
DataDrake
JoshStrobl
Staudey
Tokens
"Love" token, awarded by YakoYakoYokuYoku.

Details

Reviewers
DataDrake
JoshStrobl
Group Reviewers
Triage Team
Commits
R4981:c6787e778927: Update mozc to 2.26.4346
Summary

The differences from 2.23.2815 are

  • Replaced build system from python2 to python3
  • Added the Japanese new era(Reiwa) officially
  • Supported to import user dictionary from MS-IME
  • Added some emoji

Most of depending packages in the mozc git are updated, we don't need to download them individually now.

Test Plan

I tested ibus-mozc and fcitx-mozc on Solus Budgie 4.2.

Diff Detail

Repository
R4981 mozc
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 1562
Build 1562: arc lint + arc unit

Event Timeline

PG_MANA created this revision.Apr 25 2021, 11:56 AM
Herald added a reviewer: Triage Team. · View Herald TranscriptApr 25 2021, 11:56 AM
PG_MANA requested review of this revision.Apr 25 2021, 11:56 AM
Harbormaster completed remote builds in B128: Diff 26307.Apr 25 2021, 11:56 AM
YakoYakoYokuYoku awarded a token.Apr 25 2021, 2:58 PM
Staudey added a subscriber: Staudey.Apr 26 2021, 4:58 PM

Oh, you're back. Cool stuff :)

DataDrake accepted this revision.May 14 2021, 3:36 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.May 14 2021, 3:36 PM
DataDrake requested changes to this revision.May 14 2021, 3:37 PM
DataDrake added inline comments.
pspec_x86_64.xml
90–91

Needs to be your real name.

This revision now requires changes to proceed.May 14 2021, 3:37 PM
PG_MANA updated this revision to Diff 26737.May 14 2021, 11:59 PM

Change name to the real name

Updating D10916: Update mozc to 2.26.4346

Update mozc from 2.23.2815 to 2.26.4346

Harbormaster completed remote builds in B399: Diff 26737.May 14 2021, 11:59 PM
JoshStrobl requested changes to this revision.Aug 25 2021, 6:31 PM
JoshStrobl added a subscriber: JoshStrobl.

Sorry for the delay. Any chance we could get this updated to 439a610ac6b6a92375b4a8188d6c9ef45ea591dd ?

This revision now requires changes to proceed.Aug 25 2021, 6:31 PM
PG_MANA updated this revision to Diff 28546.Aug 26 2021, 12:27 PM
PG_MANA marked an inline comment as done.

Update mozc from 2.26.4346 to 2.26.4472(439a610ac6b6a92375b4a8188d6c9ef45ea591dd)

I tested ibus-mozc with mozc 2.26.4472 and it had no trouble.

Harbormaster completed remote builds in B1562: Diff 28546.Aug 26 2021, 12:27 PM
JoshStrobl accepted this revision.Aug 26 2021, 1:41 PM
JoshStrobl retitled this revision from Update mozc to 2.26.4346 Update mozc from 2.23.2815 to 2.26.4346 to Update mozc to 2.26.4346.
JoshStrobl edited the summary of this revision. (Show Details)

LGTM, thanks!

JoshStrobl requested changes to this revision.Aug 26 2021, 1:42 PM
JoshStrobl added inline comments.
package.yml
2

Correction, relnum needs to be bumped.

This revision now requires changes to proceed.Aug 26 2021, 1:42 PM
JoshStrobl added a comment.Sep 27 2021, 9:58 PM

@PG_MANA Any plans on fixing this?

PG_MANA updated this revision to Diff 28999.Sep 27 2021, 11:00 PM

Update mozc version from 2.26.4346.102 to 2.26.4472.102

Harbormaster completed remote builds in B1842: Diff 28999.Sep 27 2021, 11:00 PM
PG_MANA updated this revision to Diff 29000.Sep 27 2021, 11:06 PM

Fix my name to real name

Harbormaster completed remote builds in B1843: Diff 29000.Sep 27 2021, 11:06 PM
PG_MANA added a comment.Sep 27 2021, 11:06 PM

I'm sorry for missing the comment.
I updated mozc version to 2.26.4472.102 and fix my name.

JoshStrobl requested changes to this revision.Sep 27 2021, 11:32 PM

Remember, every time we update or make changes to a package, the release number needs to be incremented (assuming the prior release was included in the repo of course)

package.yml
3

Release is still set to 2 and needs to be changed to 3.

This revision now requires changes to proceed.Sep 27 2021, 11:32 PM
PG_MANA updated this revision to Diff 29002.Sep 27 2021, 11:39 PM
PG_MANA marked an inline comment as done.

Fix release number from 2 to 3

Harbormaster completed remote builds in B1844: Diff 29002.Sep 27 2021, 11:39 PM
JoshStrobl added a comment.Sep 27 2021, 11:40 PM

Forgot to get build so <Update release="2"> wasn't changed ;)

PG_MANA updated this revision to Diff 29003.Sep 27 2021, 11:45 PM

Uodate release number and releaseFrom

Harbormaster completed remote builds in B1845: Diff 29003.Sep 27 2021, 11:45 PM
PG_MANA added a comment.Sep 27 2021, 11:47 PM

I fixed the release number to 3.
I apologize for taking your time to my review.
And I appreciate your kindness comments.

JoshStrobl accepted this revision.Sep 27 2021, 11:47 PM

LGTM, thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Sep 27 2021, 11:53 PM
Closed by commit R4981:c6787e778927: Update mozc to 2.26.4346 (authored by PG_MANA, committed by JoshStrobl). · Explain Why
This revision was automatically updated to reflect the committed changes.
JoshStrobl added a commit: R4981:c6787e778927: Update mozc to 2.26.4346.

Revision Contents
Changeset List

Diff 28546

View Options

abi_used_libs

Loading...
View Options

files/gcc.patch

Loading...
View Options

files/new-era.patch

Loading...
View Options

files/protobuf-370.patch

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.