Page MenuHomeSolus
Differential D10909

audacious-plugins: switch from libmodplug to libopenmpt
ClosedPublic
Actions

Authored by aleksvor on Apr 23 2021, 4:01 PM.
Tags
None
Referenced Files
F11050070: D10909.diff
Thu, Aug 10, 6:43 PM
F10944504: D10909.id26262.diff
Fri, Jul 14, 11:55 PM
F10879169: D10909.id.diff
Jun 21 2023, 8:34 PM
F10875215: D10909.diff
Jun 20 2023, 4:38 AM
F10833097: D10909.id26262.diff
Jun 6 2023, 2:55 PM
F10828315: D10909.diff
Jun 4 2023, 9:03 AM
F10764682: D10909.id26264.diff
May 19 2023, 8:41 AM
F10764658: D10909.id26306.diff
May 19 2023, 8:34 AM
View All 12 Files
Subscribers
JoshStrobl

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Commits
R402:d4508c66178b: audacious-plugins: switch from libmodplug to libopenmpt
Summary

Switch from libmodplug to libopenmpt for supoprt of MOD files. The reasons for preferring libopenmpt are detailed in T9550.
Depends on D10908.

Test Plan

Played back 2 MOD files in Audacious.

Diff Detail

Repository
R402 audacious-plugins
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 110
Build 110: arc lint + arc unit

Event Timeline

aleksvor created this revision.Apr 23 2021, 4:01 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptApr 23 2021, 4:01 PM
aleksvor requested review of this revision.Apr 23 2021, 4:01 PM
Harbormaster completed remote builds in B110: Diff 26262.Apr 23 2021, 4:01 PM
aleksvor added inline comments.Apr 23 2021, 4:03 PM
package.yml
25

This is pulled by libopenmpt-devel.

aleksvor updated this revision to Diff 26264.Apr 23 2021, 4:14 PM

Update ABI files after a rebuild. Not sure why yabi moved cdtext_get symbol to libcue on first build, but it returns to libcdio after a rebuild.

Harbormaster completed remote builds in B111: Diff 26264.Apr 23 2021, 4:14 PM
JoshStrobl accepted this revision.Apr 25 2021, 10:42 AM
JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks!

This revision is now accepted and ready to land.Apr 25 2021, 10:42 AM
Closed by commit R402:d4508c66178b: audacious-plugins: switch from libmodplug to libopenmpt (authored by aleksvor, committed by JoshStrobl). · Explain WhyApr 25 2021, 10:59 AM
This revision was automatically updated to reflect the committed changes.
JoshStrobl added a commit: R402:d4508c66178b: audacious-plugins: switch from libmodplug to libopenmpt.

Revision Contents
Changeset List

PathSize
2 lines
10 lines
2 lines
36 lines
6 lines
6 lines

Diff 26262

View Options

abi_libs

Loading...
View Options

abi_symbols

Loading...
View Options

abi_used_libs

Loading...
View Options

abi_used_symbols

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.