Details
- Reviewers
JoshStrobl - Group Reviewers
Triage Team - Maniphest Tasks
- T6793: New MullvadVPN client
- Commits
- R5313:291c68daaa2c: The inclusion of mullvad fixes T6793
Used app and checked for IP / DNS leaks on https://mullvad.net/en/check/, there were none. Only wireguard tested. Daemon log doesn't appear to have any errors.
Diff Detail
- Repository
- R5313 mullvad
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
T6793 was closed due to lack of maintainer. I'm willing to step up as maintainer and include this initial patch.
Feedback is welcome here as I had to push a handful of patches to get everything built and packaged correctly.
I suggest you to fix the license from GPL-3.0 to GPL-3.0-or-later. Maybe the component should be network.clients.
Correction (sorry), can we get a MAINTAINERS.md file with the following contents, replacing the REPLACE ME where applicable? Thanks!
This file is used to indicate responsibility for the maintenance of this package. Individuals on this list should be the sole modifiers of the package, excluding cases where the Solus Team may need to perform necessary rebuilds, upgrades, or security fixes. This list should not be used for any direct contact usage. If you believe this package requires a package update, follow documentation from https://getsol.us/articles/packaging/request-a-package-update/en/. In the event this package no longer becomes sufficiently maintained, Core Team reserves the right to request a new maintainer or remove this package from the repository. - REPLACEME FIRST NAME(S) LAST NAME(S) - IRC: REPLACEME - Email: REPLACEME
Sounds good!
@JoshStrobl This application "notifies" in GUI when a new version is available. I'll open a ticket upstream to see if they can add a way for us to disable that. In the interim, should I try to patch out that functionality?
In the interim, should I try to patch out that functionality?
If it is not too much of a PITA, yea. Want to do that before I merge this in? Otherwise LGTM.
Yeah, I'll patch that in. I've backported my fix to the previous version and tested it works (properly disables GUI notification). I'll get this updated within the next day.
@JoshStrobl Ok this is good to go. I've added the same patch that I've submitted and appears will be accepted at https://github.com/mullvad/mullvadvpn-app/pull/2931. I've backtested this against the previous version of the app and confirmed the GUI notification is properly disabled.