Page MenuHomeSolus

The inclusion of mullvad fixes T6793
ClosedPublic

Authored by tarkah on Apr 17 2021, 9:59 PM.

Details

Summary

Inclusion of the mullvad vpn gui client and daemon.

Resolves T6793 & T9736

Test Plan

Used app and checked for IP / DNS leaks on https://mullvad.net/en/check/, there were none. Only wireguard tested. Daemon log doesn't appear to have any errors.

Diff Detail

Repository
R5313 mullvad
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tarkah created this revision.Apr 17 2021, 9:59 PM
tarkah requested review of this revision.Apr 17 2021, 9:59 PM
tarkah edited the summary of this revision. (Show Details)Apr 17 2021, 10:00 PM
tarkah edited the test plan for this revision. (Show Details)

T6793 was closed due to lack of maintainer. I'm willing to step up as maintainer and include this initial patch.

Feedback is welcome here as I had to push a handful of patches to get everything built and packaged correctly.

tarkah updated this revision to Diff 26168.Apr 19 2021, 3:56 PM

forgot to add rundep on iputils

algent added a subscriber: algent.Apr 21 2021, 7:15 AM

I suggest you to fix the license from GPL-3.0 to GPL-3.0-or-later. Maybe the component should be network.clients.

tarkah updated this revision to Diff 26185.Apr 21 2021, 3:59 PM

Updated component and license

tarkah updated this revision to Diff 26504.May 6 2021, 11:29 PM

updated to 2021.3 release

tarkah edited the summary of this revision. (Show Details)May 20 2021, 9:28 PM
tarkah updated this revision to Diff 27560.Jul 2 2021, 4:28 PM

Update to 2021.4

kimblo added a subscriber: kimblo.Jul 19 2021, 6:46 PM
riffer added a subscriber: riffer.Aug 16 2021, 7:27 PM
JoshStrobl accepted this revision.Mon, Aug 23, 1:23 PM
JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks!

This revision is now accepted and ready to land.Mon, Aug 23, 1:23 PM
JoshStrobl requested changes to this revision.Mon, Aug 23, 1:24 PM

Correction (sorry), can we get a MAINTAINERS.md file with the following contents, replacing the REPLACE ME where applicable? Thanks!

This file is used to indicate responsibility for the maintenance of this package. Individuals on this list should be the sole modifiers of the package, excluding cases where the Solus Team may need to perform necessary rebuilds, upgrades, or security fixes. This list should not be used for any direct contact usage. If you believe this package requires a package update, follow documentation from https://getsol.us/articles/packaging/request-a-package-update/en/. In the event this package no longer becomes sufficiently maintained, Core Team reserves the right to request a new maintainer or remove this package from the repository.

- REPLACEME FIRST NAME(S) LAST NAME(S)
  - IRC: REPLACEME
  - Email: REPLACEME
This revision now requires changes to proceed.Mon, Aug 23, 1:24 PM

Correction (sorry), can we get a MAINTAINERS.md file with the following contents, replacing the REPLACE ME where applicable? Thanks!

This file is used to indicate responsibility for the maintenance of this package. Individuals on this list should be the sole modifiers of the package, excluding cases where the Solus Team may need to perform necessary rebuilds, upgrades, or security fixes. This list should not be used for any direct contact usage. If you believe this package requires a package update, follow documentation from https://getsol.us/articles/packaging/request-a-package-update/en/. In the event this package no longer becomes sufficiently maintained, Core Team reserves the right to request a new maintainer or remove this package from the repository.
- REPLACEME FIRST NAME(S) LAST NAME(S)
  - IRC: REPLACEME
  - Email: REPLACEME

Sounds good!

@JoshStrobl This application "notifies" in GUI when a new version is available. I'll open a ticket upstream to see if they can add a way for us to disable that. In the interim, should I try to patch out that functionality?

tarkah updated this revision to Diff 28571.Fri, Aug 27, 10:30 PM

Add MAINTAINERS.md file

In the interim, should I try to patch out that functionality?

If it is not too much of a PITA, yea. Want to do that before I merge this in? Otherwise LGTM.

tarkah added a comment.Wed, Sep 1, 4:22 PM

In the interim, should I try to patch out that functionality?

If it is not too much of a PITA, yea. Want to do that before I merge this in? Otherwise LGTM.

Yeah, I'll patch that in. I've backported my fix to the previous version and tested it works (properly disables GUI notification). I'll get this updated within the next day.

tarkah updated this revision to Diff 28665.Thu, Sep 2, 4:29 PM

Add patch to disable GUI version update notification

tarkah added a comment.Thu, Sep 2, 4:31 PM

@JoshStrobl Ok this is good to go. I've added the same patch that I've submitted and appears will be accepted at https://github.com/mullvad/mullvadvpn-app/pull/2931. I've backtested this against the previous version of the app and confirmed the GUI notification is properly disabled.

JoshStrobl accepted this revision.Fri, Sep 3, 10:18 AM

LGTM, thanks!

This revision is now accepted and ready to land.Fri, Sep 3, 10:18 AM
This revision was automatically updated to reflect the committed changes.