Paths

Table of Contentst

Differential D10745

Rebuilt libplacebo against glslang and shaderc
AbandonedPublic
Actions

Authored by YakoYakoYokuYoku on Mar 22 2021, 8:36 PM.

Tags

None

Referenced Files

	F10822973: D10745.diff
	Sat, Jun 3, 12:57 AM

	F10748763: D10745.diff
	Mon, May 15, 10:29 PM

	F10739173: D10745.diff
	Sat, May 13, 5:19 PM

	F10738180: D10745.id25924.diff
	Sat, May 13, 10:03 AM

	F10738023: D10745.id25855.diff
	Sat, May 13, 8:44 AM

	F10719503: D10745.id.diff
	May 5 2023, 10:45 AM

	F10714699: D10745.diff
	May 3 2023, 10:18 PM

Subscribers

Details

Reviewers

None

Group Reviewers

Summary

This enables some missing Vulkan functionalities.

Depends on D10741.

Signed-off-by: Martin Reboredo <yakoyoku@gmail.com>

Test Plan

Played a video with mpv using mpv --gpu-api=vulkan.

Diff Detail

Repository

R4851 libplacebo

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

YakoYakoYokuYoku created this revision.Mar 22 2021, 8:36 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptMar 22 2021, 8:36 PM

YakoYakoYokuYoku requested review of this revision.Mar 22 2021, 8:36 PM

Thanks for this patch! I was going to switch libplacebo to shaderc myself once it's landed (as upstream prefers it over glslang).

package.yml
16–17	`glslang-devel` is not needed anymore in this case. The library links to only one compiler backend at a time, and it prefers shaderc if both are present. The missing libstdc++ in ABI report shows that glslang isn't used anymore, as the only C++ code in libplacebo is in glslang wrapper.

Remove dependency on glslang and spirv-tools.

YakoYakoYokuYoku marked an inline comment as done.Mar 26 2021, 12:59 AM

aleksvor mentioned this in D10807: Update libplacebo to 3.120.2 & switch from glslang to shaderc.Apr 3 2021, 3:10 PM

Abandoning in favor of D10807.

YakoYakoYokuYoku abandoned this revision.Apr 3 2021, 3:23 PM

Revision Contents
Changeset List

Path

Size

1 line

86 lines

3 lines

abi_used_symbols

210 lines

5 lines

pspec_x86_64.xml

14 lines

Diff 25924

abi_libs

Loading...

abi_symbols

Loading...

abi_used_libs

Loading...

abi_used_symbols

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...