Page MenuHomeSolus

Rebuilt libplacebo against glslang and shaderc
AbandonedPublic

Authored by YakoYakoYokuYoku on Mar 22 2021, 8:36 PM.

Details

Reviewers
None
Group Reviewers
Triage Team
Summary

This enables some missing Vulkan functionalities.

Depends on D10741.

Signed-off-by: Martin Reboredo <yakoyoku@gmail.com>

Test Plan

Played a video with mpv using mpv --gpu-api=vulkan.

Diff Detail

Repository
R4851 libplacebo
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

YakoYakoYokuYoku requested review of this revision.Mar 22 2021, 8:36 PM

Thanks for this patch! I was going to switch libplacebo to shaderc myself once it's landed (as upstream prefers it over glslang).

package.yml
16–17

glslang-devel is not needed anymore in this case. The library links to only one compiler backend at a time, and it prefers shaderc if both are present. The missing libstdc++ in ABI report shows that glslang isn't used anymore, as the only C++ code in libplacebo is in glslang wrapper.

Remove dependency on glslang and spirv-tools.

YakoYakoYokuYoku marked an inline comment as done.Mar 26 2021, 12:59 AM

Abandoning in favor of D10807.

YakoYakoYokuYoku abandoned this revision.Apr 3 2021, 3:23 PM