Page MenuHomeSolus

Initial commit of shaderc
ClosedPublic

Authored by YakoYakoYokuYoku on Mar 22 2021, 2:06 AM.

Details

Summary

Requirement for both gst-plugins-bad and pytorch.

Depends on D10926.

Signed-off-by: Martin Reboredo <yakoyoku@gmail.com>

Test Plan

Compiled some shaders and built against both gst-plugins-bad and pytorch.

Diff Detail

Repository
R5204 shaderc
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

YakoYakoYokuYoku requested review of this revision.Mar 22 2021, 2:06 AM

Auto formatted derp.

Employ static glslang.

aleksvor added inline comments.
package.yml
16–17

Are you sure that these are needed as rundeps? Doesn't shaderc use only static libs from -devel subpackages?

YakoYakoYokuYoku marked an inline comment as done.

Some static libraries went missing...

I thought that shaderc calls either one of them, but that wasn't the case. libplacebo runs correctly with it.

Manpage generation for glslc.

YakoYakoYokuYoku edited the summary of this revision. (Show Details)

Update to 2021.0.

JoshStrobl requested changes to this revision.Apr 25 2021, 3:25 PM
JoshStrobl added a subscriber: JoshStrobl.

Should probably use a series file and %apply_patches, you'll be at 4 patches after my requested one. https://getsol.us/articles/packaging/packaging-practices/en/#applying-a-patch

package.yml
20

What is the intention of this? If it's just to get the build version, why don't you interpolate $version into the necessary string like v${version} and echo that?

23

I'd prefer this be a patch.

This revision now requires changes to proceed.Apr 25 2021, 3:25 PM
YakoYakoYokuYoku marked 2 inline comments as done.
YakoYakoYokuYoku edited the summary of this revision. (Show Details)

Bumped glslang and patched remarked issues.

JoshStrobl accepted this revision.Apr 25 2021, 5:55 PM

Thanks for the quick fixes, LGTM, thanks!

This revision is now accepted and ready to land.Apr 25 2021, 5:55 PM

Unnecessary sed.

This revision was automatically updated to reflect the committed changes.