Requirement for both gst-plugins-bad and pytorch.
Depends on D10926.
Signed-off-by: Martin Reboredo <yakoyoku@gmail.com>
Details
Details
- Reviewers
JoshStrobl - Group Reviewers
Triage Team - Commits
- R5204:78bc0dfc3a51: Initial commit of shaderc
Compiled some shaders and built against both gst-plugins-bad and pytorch.
Diff Detail
Diff Detail
- Repository
- R5204 shaderc
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| package.yml | ||
|---|---|---|
| 16–17 | Are you sure that these are needed as rundeps? Doesn't shaderc use only static libs from -devel subpackages? | |
Comment Actions
I thought that shaderc calls either one of them, but that wasn't the case. libplacebo runs correctly with it.
Comment Actions
Should probably use a series file and %apply_patches, you'll be at 4 patches after my requested one. https://getsol.us/articles/packaging/packaging-practices/en/#applying-a-patch
| package.yml | ||
|---|---|---|
| 20 | What is the intention of this? If it's just to get the build version, why don't you interpolate $version into the necessary string like v${version} and echo that? | |
| 23 | I'd prefer this be a patch. | |