Page MenuHomeSolus

Initial commit of spotifyd
ClosedPublic

Authored by m3tav3rse on Mar 18 2021, 4:38 PM.

Details

Summary

Initial commit of spotifyd
Resolves T9631

Test Plan

Installed and run spotifyd standalone and as user service.

Diff Detail

Repository
R5171 spotifyd
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

m3tav3rse created this revision.Mar 18 2021, 4:38 PM
m3tav3rse requested review of this revision.Mar 18 2021, 4:38 PM
algent added a subscriber: algent.Mar 18 2021, 4:56 PM

Hi @m3tav3rse. As your first patch good work so far.
I suggest you to change builddeps section from this:

builddeps  :
    - cargo
    - alsa-lib-devel
    - pulseaudio-devel
    - dbus-devel

to this:

builddeps  :
    - pkgconfig(alsa)
    - pkgconfig(libpulse)
    - cargo

Because

  1. dbus-devel is part of system.devel no need to add it in package.yml.
  2. For alsa-lib-devel we should use pkgconfig(alsa) and for pulseaudio-devel we should pkgconfig(libpulse) or pkgconfig(libpulse-simple).
  3. pkgconfigs are listed first in builddeps, in this orded: from A to Z, a to z. Then other builddeps like cargo.
m3tav3rse updated this revision to Diff 25808.EditedMar 18 2021, 5:17 PM

Hi @algent. I applied changes you suggested.

As the maintainer of this package you need also a MAINTAINERS.md file.
It is something like this: https://dev.getsol.us/source/lsd/browse/master/MAINTAINERS.md

m3tav3rse updated this revision to Diff 25817.Mar 19 2021, 8:19 PM

Ok, MAINTAINERS.md added.

m3tav3rse updated this revision to Diff 25818.Mar 19 2021, 10:25 PM

Changed nick to name.

m3tav3rse updated this revision to Diff 25819.Mar 19 2021, 10:34 PM

Changed other nick to name.

JoshStrobl accepted this revision.Mar 25 2021, 8:23 AM
JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks! Congrats on your first patch, nice work!

This revision is now accepted and ready to land.Mar 25 2021, 8:23 AM
This revision was automatically updated to reflect the committed changes.