| DataDrake |
| Triage Team |
Summarized changelog:
Full changelog: https://protonmail.com/download/bridge/stable_releases.html
Synced and sent mail through Thunderbird.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
I think I accidentally had format on save active in vscode. Do you want me to revert the whitespace changes?
In the package.yml file, you have to fix the description too, from:
description: ProtonMail Bridge enable...
to:
description: |
ProtonMail Bridge enable...I found out that the ProtonMail Bridge application includes a launcher that allows it to update itself. From the ReadMe:
Official distributions of the ProtonMail Bridge and Import-Export apps contain both a launcher and the app itself. The launcher is installed in a protected area of the system (i.e. an area accessible only with admin privileges) and is used to run the app. The launcher ensures that nobody tampered with the app's files by verifying their signature using a hardcoded public key. App files are placed in regular userspace and are signed by Proton's private key. This feature enables the app to securely update itself automatically without asking the user for a password.
I tested building the launcher and it works perfectly. I installed an older version of the app and it prompted me for an update. After a restart it loaded the up-to-date application from my home directory. I would love to include this launcher in Solus if you agree. However, I am not entirely sure how to call the two resulting binaries. Currently I have:
Any thoughts? It would be great if we can include this as updates can sometimes take a while (this one has been in progress since March 4th) and this would also allow for urgent fixes by ProtonMail to be deployed to the users on short notice.
Obviously I would still regularly update the package.
If I understand this correctly, we only need to ship the launcher, not the app. The launcher will download the app (presumably in the user's homedir) on its own, facilitating its auto-update and verification process. Normally, we would try to disable the automatic updater, but the signing process won't allow us to do it that way.
The launcher (https://github.com/ProtonMail/proton-bridge/blob/master/cmd/launcher/main.go) only runs either the system wide install or a newer version from the user's home directory if present. The downloading is done by the app itself. Building only the launcher leads to:
time="Apr 23 16:19:42.932" level=fatal msg="Failed to find any launchable executable" error="no executable found"
Edit: I thought I had it working loading the prebuilt binary but now it doesn't. I'll have another look.
While I figure out the launcher business I think we should still push the latest stable release 1.6.9.
I got the launcher working. The least hacky approach would be as I proposed before. Have the launcher as protonmail-bridge the binary that everyone uses (and the current name so nothing changes for users not relying on the desktop file) and proton-bridge as the default app that we ship. This way I don't have to patch any make or desktop files.
I tried updating to a pre-release using the launcher and it works flawlessly. If you agree I can include the launcher in the 1.6.9 release.