Page MenuHomeSolus

[WIP] Initial commit of dotnet
Needs RevisionPublic

Authored by YakoYakoYokuYoku on Feb 27 2021, 9:29 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T2325: .NET Core
Summary

THIS IS WORK IN PROGRESS, DO NOT MERGE UNTIL IS FULLY READY FOR INCLUSION. I only submitted this for early reviews and comments.
After this draft is accepted (as a draft) discussions will need to take place to proceed in the inclusion of .NET Core.

The new included packages are the .NET Core 5.0 runtime and SDK. Guidelines for maintainance/rebuilds are described in the README.md.
As for the previous versions of .NET Core I'd suggest only building the runtime instead of doing the whole tarball process again.

Fixes T2325.

Signed-off-by: Martin Reboredo <yakoyoku@gmail.com>

Test Plan

Built and run a console, a game and a web project with dotnet, also packaged dotnet-format and nuget with it..

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 740
Build 740: arc lint + arc unit

Event Timeline

YakoYakoYokuYoku requested review of this revision.Feb 27 2021, 9:29 PM
RexMorgan added a subscriber: RexMorgan.

Typo in README.md and fix NETSDK1084 for Solus

Tearow added a subscriber: Tearow.Mar 1 2021, 5:29 PM

Expanded testing, corrected rundeps, tarball build and completions.

YakoYakoYokuYoku edited the test plan for this revision. (Show Details)Mar 4 2021, 7:03 PM

Update to 5.0.203.

Updated to 5.0.204 and ship dotnet-source-built-artifacts.

Built this locally using your instructions and it worked fine for me (despite the singular comment I added). Takes forever to build though, RIP build server.

dotnet-solus-tarball.sh
108

When I ran this locally it was named nuget.client.* instead of the first characters of each word being capitalized.

JoshStrobl requested changes to this revision.Aug 25 2021, 6:25 PM
JoshStrobl added a subscriber: JoshStrobl.

Marking as requesting changes since this isn't otherwise marked as pending changes from author and is still marked as WIP.

This revision now requires changes to proceed.Aug 25 2021, 6:25 PM

So I got this updated to SDK 5.0.208/Runtime 5.0.11 locally, mind if I update this diff for that? (Unfortunately 5.0.209/5.0.12 is not available in the source-build repo yet)

Also, I think that once the SDK for 6.0 is available in the source-build repo that would be an excellent time to get this merged as we wouldn't need to worry about packages that only work with 5, only packages that are updated to 6.0 in the first place are eligible for inclusion.

What is all remaining for this? Creating some ypkg macros and a set of policies that .net packages need to follow for inclusion? For the latter I propose that the self-contained feature (where packages copy the parts of the runtime they need into the executable during build time - essentially statically linking the runtime) is explicitly disallowed and packages must be patched if that's the only thing they support.