Initial inclusion of deno
ClosedPublic
Actions

Authored by peterreisz on Feb 21 2021, 9:50 AM.

Details

Reviewers

DataDrake
JoshStrobl

Group Reviewers

Triage Team

Maniphest Tasks

T9578: Deno

Commits

R5205:d7b7b7235acd: Initial inclusion of deno

Summary

Initial inclusion of deno. Resolves T9578

Test Plan

After install run the hello world script:

deno run https://deno.land/std/examples/welcome.ts

Diff Detail

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

peterreisz created this revision.Feb 21 2021, 9:50 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptFeb 21 2021, 9:50 AM

peterreisz requested review of this revision.Feb 21 2021, 9:50 AM

peterreisz added a task: T9578: Deno.Feb 21 2021, 9:52 AM

Needs a MAINTAINERS.md a la https://dev.getsol.us/source/mesalib/browse/master/MAINTAINERS.md

This revision now requires changes to proceed.Apr 23 2021, 12:59 PM

Updating D10585: Add deno package, closes T9578

Harbormaster completed remote builds in B115: Diff 26277.Apr 23 2021, 8:30 PM

Your formatting is off as well. Be sure you are generating this package.yml with our scripting: https://getsol.us/articles/packaging/packaging-practices/en/#generating-a-packageyml

package.yml
8	Doesn't need to be a list. Can just be `license : MIT`
11	Description is unnecessarily verbose. Can just be "Deno is a simple, modern and secure runtime for JavaScript and TypeScript that uses V8 and is built in Rust."
24	This is part of system.base. Not required.
25	Should be above builddeps at the very least

This revision now requires changes to proceed.Apr 25 2021, 9:44 AM

Updating D10585: Add deno package, closes T9578

Harbormaster completed remote builds in B150: Diff 26333.Apr 25 2021, 5:55 PM

In D10585#180134, @JoshStrobl wrote:

Your formatting is off as well. Be sure you are generating this package.yml with our scripting: https://getsol.us/articles/packaging/packaging-practices/en/#generating-a-packageyml

Thanks for the review, fixed all the comments.
VSCode format on save was messing up the formatting.

In D10585#180498, @peterreisz wrote:

In D10585#180134, @JoshStrobl wrote:

Your formatting is off as well. Be sure you are generating this package.yml with our scripting: https://getsol.us/articles/packaging/packaging-practices/en/#generating-a-packageyml

Thanks for the review, fixed all the comments.
VSCode format on save was messing up the formatting.