Page MenuHomeSolus

Initial inclusion of deno
ClosedPublic

Authored by peterreisz on Feb 21 2021, 9:50 AM.

Details

Summary

Initial inclusion of deno. Resolves T9578

Test Plan

After install run the hello world script:

deno run https://deno.land/std/examples/welcome.ts

Diff Detail

Repository
R5205 deno
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

peterreisz created this revision.Feb 21 2021, 9:50 AM
peterreisz requested review of this revision.Feb 21 2021, 9:50 AM
DataDrake requested changes to this revision.Apr 23 2021, 12:59 PM
DataDrake added a subscriber: DataDrake.
This revision now requires changes to proceed.Apr 23 2021, 12:59 PM
peterreisz updated this revision to Diff 26277.Apr 23 2021, 8:30 PM

Updating D10585: Add deno package, closes T9578

JoshStrobl requested changes to this revision.Apr 25 2021, 9:44 AM
JoshStrobl added a subscriber: JoshStrobl.

Your formatting is off as well. Be sure you are generating this package.yml with our scripting: https://getsol.us/articles/packaging/packaging-practices/en/#generating-a-packageyml

package.yml
8

Doesn't need to be a list. Can just be license : MIT

11

Description is unnecessarily verbose. Can just be "Deno is a simple, modern and secure runtime for JavaScript and TypeScript that uses V8 and is built in Rust."

24

This is part of system.base. Not required.

25

Should be above builddeps at the very least

This revision now requires changes to proceed.Apr 25 2021, 9:44 AM
peterreisz updated this revision to Diff 26333.Apr 25 2021, 5:55 PM

Updating D10585: Add deno package, closes T9578

peterreisz marked 4 inline comments as done.Apr 25 2021, 5:57 PM

Your formatting is off as well. Be sure you are generating this package.yml with our scripting: https://getsol.us/articles/packaging/packaging-practices/en/#generating-a-packageyml

Thanks for the review, fixed all the comments.
VSCode format on save was messing up the formatting.

JoshStrobl accepted this revision.Apr 25 2021, 6:03 PM

Your formatting is off as well. Be sure you are generating this package.yml with our scripting: https://getsol.us/articles/packaging/packaging-practices/en/#generating-a-packageyml

Thanks for the review, fixed all the comments.
VSCode format on save was messing up the formatting.

Yea, been there before :D I end up using a less fancy editor like gedit for it.

LGTM now, thanks for the patch!

JoshStrobl retitled this revision from Add deno package, closes T9578 to Initial inclusion of deno.Apr 25 2021, 6:04 PM
JoshStrobl edited the summary of this revision. (Show Details)
This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2021, 6:05 PM
Closed by commit R5205:d7b7b7235acd: Initial inclusion of deno (authored by peterreisz, committed by JoshStrobl). · Explain Why
This revision was automatically updated to reflect the committed changes.