Page MenuHomeSolus

Updates rustup to 1.23.1
ClosedPublic

Authored by peterreisz on Feb 16 2021, 5:28 PM.

Details

Summary

Changelog available here.

Test Plan

Successfully install the stable toolchain by running rustup toolchain install stable as a non-root user.

Diff Detail

Repository
R4626 rustup
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

peterreisz created this revision.Feb 16 2021, 5:28 PM
peterreisz requested review of this revision.Feb 16 2021, 5:28 PM
algent added a subscriber: algent.Feb 16 2021, 6:01 PM

Hi @peterreisz! Looks like this is your first patch.
package.yml file is fine, but I think you have edited manually pspec_x86_64.xml which in fact you should not do it. Also with our new yabi tool there should be the abi_used_symbols file.
In this case to fix this diff you have to rebuild this package.
make
make clean
git add *
git commit --amend
arc diff

peterreisz updated this revision to Diff 25430.Feb 16 2021, 6:22 PM

add abi_used_symbols

Hi @algent! Yes I've just saw this package was not updated for a while, so I thought I give it a shot.
I read the docs (https://getsol.us/articles/packaging/submitting-a-package/en/), but there was no concrete info about what should I commit and what not.
I've fixed what you asked.

Hey there, congrats on the first patch and thank you for your contribution. By any chance was there other files starting with abi in the directory? If so, could those be submitted as well. Thanks!

Hi, you're welcome. There is an abi_used_libs file, but it was already in the repo and have not changed during the make command.

JoshStrobl accepted this revision.Feb 17 2021, 5:54 PM
JoshStrobl edited the summary of this revision. (Show Details)

Thanks for taking a look. Landing :)

This revision is now accepted and ready to land.Feb 17 2021, 5:54 PM
This revision was automatically updated to reflect the committed changes.