Switch hdf5 build to autotools. CMake build generates broken CMake configuration files which then break builds of all revdeps which use CMake (namely netcdf, cgns, ParaView and VTK >= 9.0).
Autotools don't build libhdf5_tools library, but at this time nothing in the repo uses it.
Details
Details
- Reviewers
DataDrake - Group Reviewers
Triage Team - Commits
- R1396:e1ac0d6bf2f4: hdf5: switch build to autotools
Built revdeps:
- netcdf-c
- cgns
- paraview
- gdal
- octave
Diff Detail
Diff Detail
- Repository
- R1396 hdf5
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Yes, I have tested rebuilds of these against hdf5 and can confirm that they are fine. I'll update the test plan.
| package.yml | ||
|---|---|---|
| 12–22 | I'd suggest to run CMake once so we can have the *.pc files, i.e.: %cmake_ninja -DHDF5_ENABLE_Z_LIB_SUPPORT=ON -DHDF5_INSTALL_LIB_DIR=%libdir% The *.pcs reside in solusBuildDir/CMakeFiles/*.pc, then these should be installed and lastly all of them needs to be copied/symlinked to a non versioned *.pc file so that we don't have broken pkg-config dependencies. | |
| package.yml | ||
|---|---|---|
| 31 | file reports me broken links: /usr/lib64/pkgconfig/hdf5.pc: broken symbolic link to /home/build/YPKG/root/hdf5/install//usr/lib64/pkgconfig//hdf5-1.10.4.pc I'd suggest to remove $PKGCONFIGDIR/ and leave only hdf5-$version.pc, meaning that this will symlink to hdf5-$version.pc if it's in the same dir, this also applies to the rest. | |