Page MenuHomeSolus

Initial inclusion of sof-firmware
ClosedPublic

Authored by stalebrim on Feb 14 2021, 12:02 AM.

Details

Summary

Resolves T9501

Test Plan

Firmware files get installed to correct path

Diff Detail

Repository
R5326 sof-firmware
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

stalebrim created this revision.Feb 14 2021, 12:02 AM
stalebrim requested review of this revision.Feb 14 2021, 12:02 AM

Several Dell laptops are affected by the lack of this package. Are there instructions on how to install it on system before the eopk package is ready?

livingsilver94 added inline comments.
package.yml
14

I'd suggest you to use "v$version" so that we don't have to update it manually after every new release.

package.yml
13

Nope. It should be install -dm0755, not mkdir.

stalebrim updated this revision to Diff 25587.Mar 1 2021, 5:05 AM

Nonnih, better now @livingsilver94?

stalebrim marked 2 inline comments as done.Mar 1 2021, 5:07 AM

Several Dell laptops are affected by the lack of this package. Are there instructions on how to install it on system before the eopk package is ready?

I'd suggest to wait for the eopkg package to come out so you won't end up with untracked files on your root. It hopefully won't be long.

stalebrim updated this revision to Diff 25588.Mar 1 2021, 10:52 AM

Fix permissions

DataDrake requested changes to this revision.Apr 23 2021, 11:53 AM
DataDrake added a subscriber: DataDrake.
DataDrake added inline comments.
package.yml
7

This isn't a valid SPDX license. If you meant ISC as a second license, then just add it to the list.

9

I would actually put this in kernel next to linux-firmware

This revision now requires changes to proceed.Apr 23 2021, 11:53 AM
stalebrim updated this revision to Diff 26323.EditedApr 25 2021, 4:25 PM

There you go! :) Did I do the license list right?

Is it coming in an update in the near future? This affects the microphone use in my laptop, which makes very difficult to participate on Zoom meetings.

Thanks for all the efforts to bringing this to Solus.

Several Dell laptops are affected by the lack of this package. Are there instructions on how to install it on system before the eopk package is ready?

stalebrim updated this revision to Diff 26652.May 13 2021, 7:57 PM

Update to 1.7

DataDrake requested changes to this revision.May 14 2021, 1:39 PM

After it was pointed out on IRC, I think /lib/firmware makes more sense than /usr/lib/firmware on Solus.

This revision now requires changes to proceed.May 14 2021, 1:39 PM
stalebrim updated this revision to Diff 27217.Jun 14 2021, 7:36 PM

Use /lib instead of /usr/lib

JoshStrobl requested changes to this revision.Aug 25 2021, 6:27 PM
JoshStrobl added a subscriber: JoshStrobl.

LGTM but mind getting this updated to 1.8 please?

This revision now requires changes to proceed.Aug 25 2021, 6:27 PM
stalebrim added a comment.EditedAug 27 2021, 4:11 PM

LGTM but mind getting this updated to 1.8 please?

As I'm busy with various life stuff and due to switch to Fedora, I don't see myself doing any Solus packaging stuff in the foreseeable future. I wish you all good luck!

TClark77 updated this revision to Diff 28955.Sep 27 2021, 2:41 AM

Resolves T9501

Test Plan:
Verified firmware files were installed to correct path

I had asked in IRC if it would be OK to update this diff to 1.8 and received the OK

JoshStrobl requested changes to this revision.Sep 27 2021, 10:00 PM

Thanks for stepping forward @TClark77 :)

package.yml
4

Initial inclusion so release should be 1

11

above summary please

14

|- should be replaced with just |

This revision now requires changes to proceed.Sep 27 2021, 10:00 PM
TClark77 updated this revision to Diff 28998.Sep 27 2021, 10:37 PM

Review fixes

JoshStrobl accepted this revision.Sep 27 2021, 11:32 PM

LGTM, thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Sep 27 2021, 11:33 PM
This revision was automatically updated to reflect the committed changes.