Tags

None

Referenced Files

	F11071555: D10534.id25517.diff
	Sat, Aug 12, 1:37 AM

	F11071554: D10534.id25531.diff
	Sat, Aug 12, 1:37 AM

	F11053126: D10534.diff
	Thu, Aug 10, 10:41 PM

	F11017957: D10534.diff
	Sun, Aug 6, 8:14 AM

	F10931536: D10534.id25531.diff
	Jul 11 2023, 8:19 PM

	F10842222: D10534.id25373.diff
	Jun 10 2023, 10:51 AM

	F10828331: D10534.id25531.diff
	Jun 4 2023, 9:06 AM

	F10822610: D10534.id25374.diff
	Jun 2 2023, 10:43 PM

Subscribers

Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Maniphest Tasks

T9526: Alan Interactive Fiction Language

Commits

R5163:608d43f0599b: Initial commit of Alan

Summary

Initial commit of Alan. Resolves T9526

Test Plan

Build process of Alan automatically checks sample games for expected/unexpected output; currently there is only one regression

Diff Detail

Repository

R5163 alan

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

drakovyrn created this revision.Feb 12 2021, 6:34 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptFeb 12 2021, 6:34 AM

drakovyrn requested review of this revision.Feb 12 2021, 6:34 AM

drakovyrn mentioned this in T9526: Alan Interactive Fiction Language.Feb 12 2021, 6:36 AM

Changed Clang key to 'yes'

drakovyrn added a task: T9526: Alan Interactive Fiction Language.Feb 12 2021, 10:11 AM

LGTM aside from missing MAINTAINERS.md file which you were directed to in the task itself.

This revision now requires changes to proceed.Feb 20 2021, 10:37 PM

Okay, I'll revise that once I get home.

Add MAINTAINERS.md

Hey @drakovyrn, you have to fix your MAINTAINERS.md file.

Fix indentation, it should be 2 not 4.
Remove matrix and leave only Name, IRC and email.

i think leaving matrix is fine?

@algent I'm leaving Matrix in there, Joshua told me I could put it there if I had one.

I'll fix the indentation real quick.

Fix MAINTAINERS.md indentation

LGTM, thanks!

This revision is now accepted and ready to land.Mar 6 2021, 3:51 PM

Closed by commit R5163:608d43f0599b: Initial commit of Alan (authored by drakovyrn, committed by JoshStrobl). · Explain WhyMar 6 2021, 3:52 PM

This revision was automatically updated to reflect the committed changes.

JoshStrobl added a commit: R5163:608d43f0599b: Initial commit of Alan.

Initial commit of Alan
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 25681

MAINTAINERS.md

Makefile

package.yml

pspec_x86_64.xml

Initial commit of AlanClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25681

MAINTAINERS.md

Makefile

package.yml

pspec_x86_64.xml

Initial commit of Alan
ClosedPublic
Actions

Revision Contents
Changeset List