Page MenuHomeSolus
Differential D10534

Initial commit of Alan
ClosedPublic
Actions

Authored by drakovyrn on Feb 12 2021, 6:34 AM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T9526: Alan Interactive Fiction Language
Commits
R5163:608d43f0599b: Initial commit of Alan
Summary

Initial commit of Alan. Resolves T9526

Test Plan

Build process of Alan automatically checks sample games for expected/unexpected output; currently there is only one regression

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

drakovyrn created this revision.Feb 12 2021, 6:34 AM
drakovyrn requested review of this revision.Feb 12 2021, 6:34 AM
drakovyrn updated this revision to Diff 25374.Feb 12 2021, 6:59 AM

Changed Clang key to 'yes'

JoshStrobl requested changes to this revision.Feb 20 2021, 10:37 PM
JoshStrobl added a subscriber: JoshStrobl.

LGTM aside from missing MAINTAINERS.md file which you were directed to in the task itself.

This revision now requires changes to proceed.Feb 20 2021, 10:37 PM
drakovyrn added a comment.Feb 20 2021, 11:23 PM

Okay, I'll revise that once I get home.

drakovyrn updated this revision to Diff 25517.Feb 23 2021, 9:51 PM

Add MAINTAINERS.md

algent added a subscriber: algent.Feb 24 2021, 7:39 PM

Hey @drakovyrn, you have to fix your MAINTAINERS.md file.

  1. Fix indentation, it should be 2 not 4.
  2. Remove matrix and leave only Name, IRC and email.
joebonrichie added a subscriber: joebonrichie.Feb 24 2021, 7:41 PM

i think leaving matrix is fine?

drakovyrn added a comment.Feb 24 2021, 8:04 PM

@algent I'm leaving Matrix in there, Joshua told me I could put it there if I had one.

I'll fix the indentation real quick.

drakovyrn updated this revision to Diff 25531.Feb 24 2021, 8:07 PM

Fix MAINTAINERS.md indentation

JoshStrobl accepted this revision.Mar 6 2021, 3:51 PM
JoshStrobl edited the summary of this revision. (Show Details)

LGTM, thanks!

This revision is now accepted and ready to land.Mar 6 2021, 3:51 PM
Closed by commit R5163:608d43f0599b: Initial commit of Alan (authored by drakovyrn, committed by JoshStrobl). · Explain WhyMar 6 2021, 3:52 PM
This revision was automatically updated to reflect the committed changes.
JoshStrobl added a commit: R5163:608d43f0599b: Initial commit of Alan.

Revision Contents
Changeset List

PathPackages
AMMakefile (1 line)
AMpackage.yml (23 lines)
AMpspec_x86_64.xml (37 lines)

Diff 25373

View Options

Makefile

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.