Page MenuHomeSolus

Initial commit of Alan
Needs ReviewPublic

Authored by drakovyrn on Fri, Feb 12, 6:34 AM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T9526: Alan Interactive Fiction Language
Summary

Initial commit of Alan

Test Plan

Build process of Alan automatically checks sample games for expected/unexpected output; currently there is only one regression

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

drakovyrn created this revision.Fri, Feb 12, 6:34 AM
drakovyrn requested review of this revision.Fri, Feb 12, 6:34 AM
drakovyrn updated this revision to Diff 25374.Fri, Feb 12, 6:59 AM

Changed Clang key to 'yes'

JoshStrobl requested changes to this revision.Sat, Feb 20, 10:37 PM
JoshStrobl added a subscriber: JoshStrobl.

LGTM aside from missing MAINTAINERS.md file which you were directed to in the task itself.

This revision now requires changes to proceed.Sat, Feb 20, 10:37 PM

Okay, I'll revise that once I get home.

drakovyrn updated this revision to Diff 25517.Tue, Feb 23, 9:51 PM

Add MAINTAINERS.md

algent added a subscriber: algent.Wed, Feb 24, 7:39 PM

Hey @drakovyrn, you have to fix your MAINTAINERS.md file.

  1. Fix indentation, it should be 2 not 4.
  2. Remove matrix and leave only Name, IRC and email.

i think leaving matrix is fine?

@algent I'm leaving Matrix in there, Joshua told me I could put it there if I had one.

I'll fix the indentation real quick.

drakovyrn updated this revision to Diff 25531.Wed, Feb 24, 8:07 PM

Fix MAINTAINERS.md indentation