Initial commit of alpine - the console-based email client.
Details
Details
- Reviewers
DataDrake JoshStrobl - Group Reviewers
Triage Team - Commits
- R5162:4211abd94198: Initial working Alpine
Installed, checked email with SSL, sent email with TLS, able to save passwords in a local password file.
Diff Detail
Diff Detail
- Repository
- R5162 alpine
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
| package.yml | ||
|---|---|---|
| 16 | Is this going to be in $HOME? If that's the case, it should probably be in ~/.config or ~/.cache instead (whichever is appropriate for the purpose of the file) | |
Comment Actions
@serebit not worth it:
/usr/spool/mail/xxxx Default folder for incoming mail. ~/mail Default directory for mail folders. ~/.addressbook Default address book file. ~/.signature File used for signature, appended to every message. ~/.pine-debug[1-4] Diagnostic log for debugging. ~/.pinerc Personal alpine config file. ~/.pine-crash Debug information useful to debug a crash. ~/.newsrc News subscription/state file. ~/.mailcap Personal mail capabilities file. ~/.mime.types Personal file extension to MIME type mapping /etc/mailcap System-wide mail capabilities file. /etc/mime.types System-wide file ext. to MIME type mapping /usr/local/lib/pine.info Local pointer to system administrator. /usr/local/lib/pine.conf System-wide configuration file. /usr/local/lib/pine.conf.fixed Non-overridable configuration file. ~/.alpine-smime/ca Directory that contains Certificate Authority files. ~/.alpine-smime/private Directory that contains private key(s). ~/.alpine-smime/public Directory that contains public key(s). /tmp/.\usr\spool\mail\xxxx Per-folder mailbox lock files. ~/.pine-interrupted-mail Message which was interrupted. ~/mail/postponed-msgs For postponed messages (drafts) ~/mail/sent-mail Outgoing message archive (FCC). ~/mail/saved-messages Default destination for Saving messages.
@hansk See inline comments. Minor things, but a nice first go at this. Cheers.
| package.yml | ||
|---|---|---|
| 8 | Should be network.mail | |
| 13 | pkgconfig() goes first in our alphabetical ordering (I know, weird) | |
| package.yml | ||
|---|---|---|
| 3 | You don't need to bump it yet, it hasn't landed. Can set it back to 1. | |
Comment Actions
The patch itself looks good, I appreciate you taking the time to package this. While it isn't included in our current packaging documentation (sorry, working on lots of things), we do generally require a file called MAINTAINERS.md for all new packages. This file indicates the individual responsible for it and is useful for us when doing various checks / searches, and will be more useful in future infrastructure changes. Please include this file in your patch, replacing the relevant content below:
This file is used to indicate responsibility for the maintenance of this package. Individuals on this list should be the sole modifiers of the package, excluding cases where the Solus Team may need to perform necessary rebuilds, upgrades, or security fixes. This list should not be used for any direct contact usage. If you believe this package requires a package update, follow documentation from https://getsol.us/articles/packaging/request-a-package-update/en/. In the event this package no longer becomes sufficiently maintained, Core Team reserves the right to request a new maintainer or remove this package from the repository. - REPLACEME FIRST NAME(S) LAST NAME(S) - IRC: REPLACEME - Email: REPLACEME