pspec_x86_64.xml
62	Have you tested whether or not this could be a shared lib instead of static, and whether or not it needs to be in the main package? https://github.com/WebAssembly/wabt/blob/master/CMakeLists.txt#L351 might be it.

Patch CMakeLists.txt for a wasm-rt-impl shared library.

LGTM but just wanting to confirm that you actually built stuff against this with the change? For example there was a change made to openshadinglanguage that clearly wasn't validated against blender after the changes were made and I ended up needing to fix it while landing it and blender.

Trying to avoid having to do that stuff again :P

emscripten is the only revdep and it's a rundep, also I've retested the commands again with full success.

Cheers!

This revision is now accepted and ready to land.Mar 3 2021, 5:33 PM

Closed by commit R5004:5ebc7cbc5e47: Update wabt to 1.0.20 (authored by YakoYakoYokuYoku, committed by JoshStrobl). · Explain WhyMar 3 2021, 6:35 PM

This revision was automatically updated to reflect the committed changes.

JoshStrobl added a commit: R5004:5ebc7cbc5e47: Update wabt to 1.0.20.

Revision Contents
Changeset List

		Path
A	M	abi_libs (1 line)
A	M	abi_symbols (11 lines)
A	M	abi_used_symbols (93 lines)
A	M	files/shared-wasm-rt-impl.patch (22 lines)
M		package.yml (15 lines)
M		pspec_x86_64.xml (27 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	25240	e582760		Jan 31 2021, 9:25 PM	★	★
Diff 2	25264	e582760	Patch `CMakeLists.txt` for a `wasm-rt-impl` shared library.	Feb 1 2021, 6:53 PM	★	★
Diff 3	25621	e582760	R5004:5ebc7cbc5e478f6181661b4728165321e8393357	Mar 3 2021, 6:35 PM	★	★

Status	Author	Revision
Closed	YakoYakoYokuYoku	D10481 Update emscripten to 2.0.14
Closed	YakoYakoYokuYoku	D10480 Update closure-compiler to 20210202
Closed	YakoYakoYokuYoku	D10479 Update wabt to 1.0.20
Closed	YakoYakoYokuYoku	D10478 Update binaryen to 99