Page MenuHomeSolus

Update wabt to 1.0.20
ClosedPublic

Authored by YakoYakoYokuYoku on Jan 31 2021, 9:25 PM.

Details

Summary

Changelog:

  • 1.0.20:
    • Rename atomic.notify, *.atomic.wait to memory.atomic.*.
  • 1.0.19:
    • Completely disable signal handler on 32-bit.
  • 1.0.18:
    • Use #warning instead of #warn.

Signed-off-by: Martin Reboredo <yakoyoku@gmail.com>

Test Plan

Run wasm-validate and wasm-strip on a WebAssembly file.

Diff Detail

Repository
R5004 wabt
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

YakoYakoYokuYoku requested review of this revision.Jan 31 2021, 9:25 PM
JoshStrobl added inline comments.
pspec_x86_64.xml
62

Have you tested whether or not this could be a shared lib instead of static, and whether or not it needs to be in the main package?

https://github.com/WebAssembly/wabt/blob/master/CMakeLists.txt#L351 might be it.

YakoYakoYokuYoku marked an inline comment as done.

Patch CMakeLists.txt for a wasm-rt-impl shared library.

LGTM but just wanting to confirm that you actually built stuff against this with the change? For example there was a change made to openshadinglanguage that clearly wasn't validated against blender after the changes were made and I ended up needing to fix it while landing it and blender.

Trying to avoid having to do that stuff again :P

emscripten is the only revdep and it's a rundep, also I've retested the commands again with full success.

JoshStrobl accepted this revision.Mar 3 2021, 5:33 PM

Cheers!

This revision is now accepted and ready to land.Mar 3 2021, 5:33 PM
This revision was automatically updated to reflect the committed changes.