Page MenuHomeSolus

Update weechat to 3.0.1
ClosedPublic

Authored by EbonJaeger on Jan 31 2021, 5:34 PM.

Details

Summary

Changelog:

  • Fix search of command by identifier
  • Fix refresh of bar item spell_suggest when the input becomes empty
  • Fix crash with IRC color codes in command line
Test Plan

Connected to Freenode IRC, sent and received chat messages

Diff Detail

Repository
R3160 weechat
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

EbonJaeger created this revision.Jan 31 2021, 5:34 PM
EbonJaeger requested review of this revision.Jan 31 2021, 5:34 PM

Using the new yabi tool, this detects stuff from an unknown library, even after building it with Weechat's devel package installed. I'm not sure what package I'm missing, but if anyone knows, I can rebuild after making sure it's installed on my system so we have the correct library and symbol information.

algent added a subscriber: algent.Jan 31 2021, 7:37 PM

I don't think you are missing something. From google searches gzclose, gzeof and gzgets are zlib functions and zlib-devel is already installed when compiling weechat, because zlib-devel is a dependency of tcl-devel which is pkgconfig(tcl) in package.yml file.

the stuff needs to be installed on your system as well

@algent the new tool currently is only able to look at the actual system because it's not running in the solbuild chroot. That said, I did have zlib-devel installed already, so I really don't know. Thanks for figuring out the package though! Maybe that can be of some use.

EbonJaeger planned changes to this revision.Feb 1 2021, 5:27 AM

With the update to abi-wizard 1.0.4, the zlib stuff gets found correctly. Now it just seems to be a couple symbols from glibc-devel. Will look into after waking up.

EbonJaeger updated this revision to Diff 25249.Feb 1 2021, 4:13 PM

Update missing symbols for zlib

Still has two unknown symbols, believed from glibc-devel.

JoshStrobl accepted this revision.Feb 1 2021, 5:44 PM
JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks!

This revision is now accepted and ready to land.Feb 1 2021, 5:44 PM
This revision was automatically updated to reflect the committed changes.