Page MenuHomeSolus

Update deadbeef to 1.8.6
ClosedPublic

Authored by stalebrim on Jan 31 2021, 5:24 AM.

Details

Summary

Depends on D10469

Changelog available here

Packaging updates:

  • Enabled CD audio support
Test Plan
  • Listen to some music
  • Test CD audio

Diff Detail

Repository
R607 deadbeef
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

stalebrim created this revision.Jan 31 2021, 5:24 AM
stalebrim requested review of this revision.Jan 31 2021, 5:24 AM
stalebrim abandoned this revision.Jan 31 2021, 5:25 AM

There's something weird with it

stalebrim updated this revision to Diff 25221.Jan 31 2021, 5:32 AM

Now it should be alright

stalebrim abandoned this revision.Jan 31 2021, 5:37 AM
stalebrim updated this revision to Diff 25224.Jan 31 2021, 6:39 AM

Rebase

Dunno what's going on with that UNKNOWN stuff. I suspect they're actually its own functions instead of separate libs

JoshStrobl accepted this revision.Feb 2 2021, 7:00 AM
JoshStrobl edited the summary of this revision. (Show Details)
JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks!

This revision is now accepted and ready to land.Feb 2 2021, 7:00 AM
stalebrim updated this revision to Diff 25281.Feb 3 2021, 8:18 PM

Rebase. Enable CD Audio support (tested)

stalebrim edited the summary of this revision. (Show Details)Feb 3 2021, 8:18 PM
stalebrim edited the test plan for this revision. (Show Details)
JoshStrobl requested changes to this revision.Feb 11 2021, 8:19 AM
JoshStrobl added inline comments.
package.yml
23

This can be removed as you specified the one from libcdio-paranoia-devel.

This revision now requires changes to proceed.Feb 11 2021, 8:19 AM
stalebrim updated this revision to Diff 25403.Feb 13 2021, 11:35 PM
stalebrim marked an inline comment as done.

Remove redundant dep

JoshStrobl accepted this revision.Feb 17 2021, 6:06 PM

LGTM, thanks!

This revision is now accepted and ready to land.Feb 17 2021, 6:06 PM
This revision was automatically updated to reflect the committed changes.