Page MenuHomeSolus
Differential D10469

Initial inclusion of libdispatch
ClosedPublic
Actions

Authored by stalebrim on Jan 31 2021, 5:23 AM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Commits
R5151:ff24e3a2d674: Initial inclusion of libdispatch
Summary

Depends on D10468

Test Plan
  • Tests pass
  • Build deadbeef 1.8.6

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

stalebrim created this revision.Jan 31 2021, 5:23 AM
stalebrim requested review of this revision.Jan 31 2021, 5:23 AM
stalebrim added a child revision: D10470: Update deadbeef to 1.8.6.
stalebrim abandoned this revision.Jan 31 2021, 5:37 AM
stalebrim updated this revision to Diff 25223.Jan 31 2021, 6:38 AM

Build against libblocksruntime

JoshStrobl requested changes to this revision.Feb 1 2021, 5:57 PM
JoshStrobl added a subscriber: JoshStrobl.

Maybe worth explicitly adding libblocksruntime-devel as a rundep for libdispatch-devel

package.yml
10

programming.library

pspec_x86_64.xml
68

libsplit: no so we have the .so file in the main package, that way (in theory) deadbeef won't be trying to pull in libdispatch-devel with all the devel headers.

This revision now requires changes to proceed.Feb 1 2021, 5:57 PM
stalebrim updated this revision to Diff 25280.Feb 3 2021, 8:15 PM

Made the changes Josh requested

JoshStrobl requested changes to this revision.Feb 5 2021, 5:59 AM
JoshStrobl added inline comments.
package.yml
16

libblocksruntime-devel should have a rundep on libblocksruntime

This revision now requires changes to proceed.Feb 5 2021, 5:59 AM
JoshStrobl accepted this revision.Feb 11 2021, 8:20 AM

LGTM, thanks!

This revision is now accepted and ready to land.Feb 11 2021, 8:20 AM
Closed by commit R5151:ff24e3a2d674: Initial inclusion of libdispatch (authored by stalebrim, committed by JoshStrobl). · Explain WhyFeb 17 2021, 6:32 PM
This revision was automatically updated to reflect the committed changes.
JoshStrobl added a commit: R5151:ff24e3a2d674: Initial inclusion of libdispatch.

Revision Contents
Changeset List

PathPackages
AMMakefile (1 line)
AMabi_libs (1 line)
AMabi_symbols (191 lines)
AMabi_used_libs (5 lines)
AMabi_used_symbols (88 lines)
AMfiles/remove-werror.patch (10 lines)
AMfiles/system-blocksruntime.patch (21 lines)
AMpackage.yml (26 lines)
AMpspec_x86_64.xml (79 lines)

Diff 25323

View Options

Makefile

Loading...
View Options

abi_libs

Loading...
View Options

abi_symbols

Loading...
View Options

abi_used_libs

Loading...
View Options

abi_used_symbols

Loading...
View Options

files/remove-werror.patch

Loading...
View Options

files/system-blocksruntime.patch

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.