Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Commits

R5151:ff24e3a2d674: Initial inclusion of libdispatch

Summary

Depends on D10468

Test Plan

Tests pass
Build deadbeef 1.8.6

Diff Detail

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Event Timeline

stalebrim created this revision.Jan 31 2021, 5:23 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptJan 31 2021, 5:23 AM

stalebrim requested review of this revision.Jan 31 2021, 5:23 AM

stalebrim added a child revision: D10470: Update deadbeef to 1.8.6.

stalebrim abandoned this revision.Jan 31 2021, 5:37 AM

Build against libblocksruntime

Maybe worth explicitly adding libblocksruntime-devel as a rundep for libdispatch-devel

package.yml
10	programming.library
pspec_x86_64.xml
68	`libsplit: no` so we have the .so file in the main package, that way (in theory) deadbeef won't be trying to pull in libdispatch-devel with all the devel headers.

This revision now requires changes to proceed.Feb 1 2021, 5:57 PM

Made the changes Josh requested

JoshStrobl requested changes to this revision.Feb 5 2021, 5:59 AM

JoshStrobl added inline comments.

package.yml
16	libblocksruntime-devel should have a rundep on libblocksruntime

This revision now requires changes to proceed.Feb 5 2021, 5:59 AM

Fixed

LGTM, thanks!

This revision is now accepted and ready to land.Feb 11 2021, 8:20 AM

Closed by commit R5151:ff24e3a2d674: Initial inclusion of libdispatch (authored by stalebrim, committed by JoshStrobl). · Explain WhyFeb 17 2021, 6:32 PM

This revision was automatically updated to reflect the committed changes.

JoshStrobl added a commit: R5151:ff24e3a2d674: Initial inclusion of libdispatch.

		Path
A	M	Makefile (1 line)
A	M	abi_libs (1 line)
A	M	abi_symbols (191 lines)
A	M	abi_used_libs (5 lines)
A	M	abi_used_symbols (88 lines)
A	M	files/remove-werror.patch (10 lines)
A	M	files/system-blocksruntime.patch (21 lines)
A	M	package.yml (26 lines)
A	M	pspec_x86_64.xml (79 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	25219	4b825dc		Jan 31 2021, 5:23 AM	★	★
Diff 2	25223	4b825dc	Build against libblocksruntime	Jan 31 2021, 6:38 AM	★	★
Diff 3	25280	4b825dc	Made the changes Josh requested	Feb 3 2021, 8:15 PM	★	★
Diff 4	25323	4b825dc	Fixed	Feb 7 2021, 5:53 PM	★	★
Diff 5	25462	4749d2c	R5151:ff24e3a2d674fc0f0b5416b0077ee4720517ad99	Feb 17 2021, 6:31 PM	★	★

Initial inclusion of libdispatch
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 25323

Makefile

abi_libs

abi_symbols

abi_used_libs

abi_used_symbols

files/remove-werror.patch

files/system-blocksruntime.patch

package.yml

pspec_x86_64.xml

Initial inclusion of libdispatchClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25323

Makefile

abi_libs

abi_symbols

abi_used_libs

abi_used_symbols

files/remove-werror.patch

files/system-blocksruntime.patch

package.yml

pspec_x86_64.xml

Initial inclusion of libdispatch
ClosedPublic
Actions

Revision Contents
Changeset List