Page MenuHomeSolus

Initial inclusion of libdispatch
ClosedPublic

Authored by stalebrim on Jan 31 2021, 5:23 AM.

Details

Summary

Depends on D10468

Test Plan
  • Tests pass
  • Build deadbeef 1.8.6

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

stalebrim created this revision.Jan 31 2021, 5:23 AM
stalebrim requested review of this revision.Jan 31 2021, 5:23 AM
stalebrim abandoned this revision.Jan 31 2021, 5:37 AM
stalebrim updated this revision to Diff 25223.Jan 31 2021, 6:38 AM

Build against libblocksruntime

JoshStrobl requested changes to this revision.Feb 1 2021, 5:57 PM
JoshStrobl added a subscriber: JoshStrobl.

Maybe worth explicitly adding libblocksruntime-devel as a rundep for libdispatch-devel

package.yml
9

programming.library

pspec_x86_64.xml
67

libsplit: no so we have the .so file in the main package, that way (in theory) deadbeef won't be trying to pull in libdispatch-devel with all the devel headers.

This revision now requires changes to proceed.Feb 1 2021, 5:57 PM
stalebrim updated this revision to Diff 25280.Feb 3 2021, 8:15 PM

Made the changes Josh requested

JoshStrobl requested changes to this revision.Feb 5 2021, 5:59 AM
JoshStrobl added inline comments.
package.yml
16

libblocksruntime-devel should have a rundep on libblocksruntime

This revision now requires changes to proceed.Feb 5 2021, 5:59 AM
JoshStrobl accepted this revision.Feb 11 2021, 8:20 AM

LGTM, thanks!

This revision is now accepted and ready to land.Feb 11 2021, 8:20 AM
This revision was automatically updated to reflect the committed changes.