Tags

None

Referenced Files

	F10822980: D10469.id25219.diff
	Sat, Jun 3, 1:01 AM

	F10804416: D10469.id25323.diff
	Mon, May 29, 4:01 PM

	F10773017: D10469.id.diff
	Sun, May 21, 4:45 PM

	F10743565: D10469.id25280.diff
	Sun, May 14, 8:56 PM

	F10743489: D10469.id25462.diff
	Sun, May 14, 8:29 PM

	F10743458: D10469.id25223.diff
	Sun, May 14, 8:19 PM

	F10743453: D10469.id25323.diff
	Sun, May 14, 8:17 PM

	F10743447: D10469.id25219.diff
	Sun, May 14, 8:15 PM

View All 11 Files

Subscribers

JoshStrobl

Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Commits

R5151:ff24e3a2d674: Initial inclusion of libdispatch

Summary

Depends on D10468

Test Plan

Tests pass
Build deadbeef 1.8.6

Diff Detail

Repository

R5151 libdispatch

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

stalebrim created this revision.Jan 31 2021, 5:23 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptJan 31 2021, 5:23 AM

stalebrim requested review of this revision.Jan 31 2021, 5:23 AM

stalebrim added a child revision: D10470: Update deadbeef to 1.8.6.

stalebrim abandoned this revision.Jan 31 2021, 5:37 AM

Build against libblocksruntime

Maybe worth explicitly adding libblocksruntime-devel as a rundep for libdispatch-devel

package.yml
10	programming.library
pspec_x86_64.xml
68	`libsplit: no` so we have the .so file in the main package, that way (in theory) deadbeef won't be trying to pull in libdispatch-devel with all the devel headers.

This revision now requires changes to proceed.Feb 1 2021, 5:57 PM

Made the changes Josh requested

JoshStrobl requested changes to this revision.Feb 5 2021, 5:59 AM

JoshStrobl added inline comments.

package.yml
16	libblocksruntime-devel should have a rundep on libblocksruntime

This revision now requires changes to proceed.Feb 5 2021, 5:59 AM

Fixed

LGTM, thanks!

This revision is now accepted and ready to land.Feb 11 2021, 8:20 AM

Closed by commit R5151:ff24e3a2d674: Initial inclusion of libdispatch (authored by stalebrim, committed by JoshStrobl). · Explain WhyFeb 17 2021, 6:32 PM

This revision was automatically updated to reflect the committed changes.

JoshStrobl added a commit: R5151:ff24e3a2d674: Initial inclusion of libdispatch.

Initial inclusion of libdispatch
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 25462

Makefile

abi_libs

abi_symbols

abi_used_libs

abi_used_symbols

files/remove-werror.patch

files/system-blocksruntime.patch

package.yml

pspec_x86_64.xml

Initial inclusion of libdispatchClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25462

Makefile

abi_libs

abi_symbols

abi_used_libs

abi_used_symbols

files/remove-werror.patch

files/system-blocksruntime.patch

package.yml

pspec_x86_64.xml

Initial inclusion of libdispatch
ClosedPublic
Actions

Revision Contents
Changeset List